Skip to content

Commit 157aa8a

Browse files
committed
add nopoison back
1 parent 5127b51 commit 157aa8a

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

llvm/lib/Transforms/Scalar/ConstraintElimination.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1134,7 +1134,6 @@ void State::addInfoFor(BasicBlock &BB) {
11341134
case Intrinsic::smin:
11351135
case Intrinsic::smax:
11361136
case Intrinsic::usub_sat:
1137-
// TODO: handle llvm.abs as well
11381137
WorkList.push_back(
11391138
FactOrCheck::getCheck(DT.getNode(&BB), cast<CallInst>(&I)));
11401139
// TODO: Check if it is possible to instead only added the min/max facts

llvm/test/Transforms/ConstraintElimination/abs.ll

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,8 @@ define i1 @abs_plus_one_unsigned_greater_or_equal_nonnegative_arg(i32 %arg) {
7272
; CHECK-SAME: i32 [[ARG:%.*]]) {
7373
; CHECK-NEXT: [[CMP_ARG_NONNEGATIVE:%.*]] = icmp sge i32 [[ARG]], 0
7474
; CHECK-NEXT: call void @llvm.assume(i1 [[CMP_ARG_NONNEGATIVE]])
75-
; CHECK-NEXT: [[ABS:%.*]] = tail call i32 @llvm.abs.i32(i32 [[ARG]], i1 true)
76-
; CHECK-NEXT: [[ABS_PLUS_ONE:%.*]] = add nuw i32 [[ABS]], 1
77-
; CHECK-NEXT: [[CMP:%.*]] = icmp uge i32 [[ABS_PLUS_ONE]], [[ARG]]
78-
; CHECK-NEXT: ret i1 [[CMP]]
75+
; CHECK-NEXT: [[ABS_PLUS_ONE:%.*]] = add nuw i32 [[ARG]], 1
76+
; CHECK-NEXT: ret i1 true
7977
;
8078
%cmp_arg_nonnegative = icmp sge i32 %arg, 0
8179
call void @llvm.assume(i1 %cmp_arg_nonnegative)
@@ -155,9 +153,7 @@ define i1 @abs_is_nonnegative_int_min_is_poison(i32 %arg) {
155153

156154
define i1 @abs_is_nonnegative_constant_arg() {
157155
; CHECK-LABEL: define i1 @abs_is_nonnegative_constant_arg() {
158-
; CHECK-NEXT: [[ABS:%.*]] = tail call i32 @llvm.abs.i32(i32 -3, i1 true)
159-
; CHECK-NEXT: [[CMP:%.*]] = icmp sge i32 [[ABS]], 0
160-
; CHECK-NEXT: ret i1 [[CMP]]
156+
; CHECK-NEXT: ret i1 true
161157
;
162158
%abs = tail call i32 @llvm.abs.i32(i32 -3, i1 true)
163159
%cmp = icmp sge i32 %abs, 0

0 commit comments

Comments
 (0)