[GSYM] Avoid repeated hash lookups (NFC) (#109241)

kazutakahirata · web-flow · commit 157adcccc59c · 2024-09-19T09:14:45.000-07:00
diff --git a/llvm/lib/DebugInfo/GSYM/GsymCreator.cpp b/llvm/lib/DebugInfo/GSYM/GsymCreator.cpp
@@ -375,8 +375,7 @@ uint32_t GsymCreator::insertString(StringRef S, bool Copy) {
   // Save a mapping of string offsets to the cached string reference in case
   // we need to segment the GSYM file and copy string from one string table to
   // another.
-  if (StringOffsetMap.count(StrOff) == 0)
-    StringOffsetMap.insert(std::make_pair(StrOff, CHStr));
+  StringOffsetMap.try_emplace(StrOff, CHStr);
   return StrOff;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -375,8 +375,7 @@ uint32_t GsymCreator::insertString(StringRef S, bool Copy) {`
`375`	`375`	`// Save a mapping of string offsets to the cached string reference in case`
`376`	`376`	`// we need to segment the GSYM file and copy string from one string table to`
`377`	`377`	`// another.`
`378`		`- if (StringOffsetMap.count(StrOff) == 0)`
`379`		`- StringOffsetMap.insert(std::make_pair(StrOff, CHStr));`
	`378`	`+ StringOffsetMap.try_emplace(StrOff, CHStr);`
`380`	`379`	`return StrOff;`
`381`	`380`	`}`
`382`	`381`