Address comments

Author: Groverkss

mlir/include/mlir/Dialect/Vector/Transforms/LoweringPatterns.h

@@ -241,8 +241,8 @@ void populateVectorStepLoweringPatterns(RewritePatternSet &patterns,
 
 /// Populate the pattern set with the following patterns:
 ///
-/// [FlattenGather]
-/// Flattens 2 or more dimensional `vector.gather` ops by unrolling the
+/// [UnrollGather]
+/// Unrolls 2 or more dimensional `vector.gather` ops by unrolling the
 /// outermost dimension.
 void populateVectorGatherLoweringPatterns(RewritePatternSet &patterns,
                                           PatternBenefit benefit = 1);

mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp

@@ -273,7 +273,7 @@ class VectorGatherOpConversion
     if (vType.getRank() > 1)
       return failure();
 
-    auto loc = gather->getLoc();
+    Location loc = gather->getLoc();
 
     // Resolve alignment.
     unsigned align;
@@ -284,12 +284,10 @@ class VectorGatherOpConversion
     Value ptr = getStridedElementPtr(loc, memRefType, adaptor.getBase(),
                                      adaptor.getIndices(), rewriter);
     Value base = adaptor.getBase();
-
-    // Handle the simple case of 1-D vector.
-    // Resolve address.
     Value ptrs =
         getIndexedPtrs(rewriter, loc, *this->getTypeConverter(), memRefType,
                        base, ptr, adaptor.getIndexVec(), vType);
+
     // Replace with the gather intrinsic.
     rewriter.replaceOpWithNewOp<LLVM::masked_gather>(
         gather, typeConverter->convertType(vType), ptrs, adaptor.getMask(),

mlir/lib/Dialect/Vector/Transforms/LowerVectorGather.cpp

@@ -107,8 +107,8 @@ struct UnrollGather : OpRewritePattern<vector::GatherOp> {
 /// ```mlir
 ///   %subview = memref.subview %M (...)
 ///     : memref<100x3xf32> to memref<100xf32, strided<[3]>>
-///   %gather = vector.gather %subview[%idxs] (...) : memref<100xf32,
-///   strided<[3]>>
+///   %gather = vector.gather %subview[%idxs] (...)
+///     : memref<100xf32, strided<[3]>>
 /// ```
 /// ==>
 /// ```mlir

mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir

@@ -1677,7 +1677,7 @@ func.func @gather_with_mask(%arg0: memref<?xf32>, %arg1: vector<2x3xi32>, %arg2:
 func.func @gather_with_mask_scalable(%arg0: memref<?xf32>, %arg1: vector<2x[3]xi32>, %arg2: vector<2x[3]xf32>) -> vector<2x[3]xf32> {
   %0 = arith.constant 0: index
   // vector.constant_mask only supports 'none set' or 'all set' scalable
-  // dimensions, hence [1, 3] rather than [1, 2] as in the example for fixed
+  // dimensions, hence [2, 3] rather than [2, 2] as in the example for fixed
   // width vectors above.
   %1 = vector.constant_mask [2, 3] : vector<2x[3]xi1>
   %2 = vector.gather %arg0[%0][%arg1], %1, %arg2 : memref<?xf32>, vector<2x[3]xi32>, vector<2x[3]xi1>, vector<2x[3]xf32> into vector<2x[3]xf32>