Skip to content

Commit 1608c82

Browse files
committed
[clang] [test] Skip a test that sets PATH= on Windows
The same has been done in a couple other existing tests, that also are skipped on Windows (e.g. ld-path.c). Some tests that really do want to test setting the path on Windows does it differently, see e.g. ps4-ps5-linker-win.c. Since a65771f, the spirv-toolchain.cl test does one test where PATH is set. Setting PATH does work in some build configurations - however, if built with e.g. llvm-mingw, the built Clang executable depends on libc++.dll (and libunwind.dll) which are found in PATH. If the PATH is overridden, the newly built Clang executable no longer can run.
1 parent 9dfd076 commit 1608c82

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

clang/test/Driver/spirv-toolchain.cl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
/// One test uses the PATH environment variable; on Windows, we may need to retain
2+
/// the original path for the built Clang binary to be able to execute (as it is
3+
/// used for locating dependent DLLs).
4+
// UNSUPPORTED: system-windows
5+
16
// Check object emission.
27
// RUN: %clang -### --target=spirv64 -x cl -c %s 2>&1 | FileCheck --check-prefix=SPV64 %s
38
// RUN: %clang -### --target=spirv64 %s 2>&1 | FileCheck --check-prefix=SPV64 %s

0 commit comments

Comments
 (0)