Skip to content

Commit 16e1a49

Browse files
committed
Revert "[cmake][msvc] Enable standards-conforming preprocessor"
This reverts commit 12d8e7c. The Windows MLIR buildbot started failing with: C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winbase.h(9531): error C2220: the following warning is treated as an error C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winbase.h(9531): warning C5105: macro expansion producing 'defined' has undefined behavior C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winbase.h(9531): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
1 parent e4b126c commit 16e1a49

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

llvm/cmake/modules/HandleLLVMOptions.cmake

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -481,10 +481,6 @@ if( MSVC )
481481

482482
append("/Zc:inline" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
483483

484-
# Enable standards-conforming preprocessor.
485-
# https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor
486-
append("/Zc:preprocessor" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
487-
488484
# Some projects use the __cplusplus preprocessor macro to check support for
489485
# a particular version of the C++ standard. When this option is not specified
490486
# explicitly, macro's value is "199711L" that implies C++98 Standard.

0 commit comments

Comments
 (0)