Revision 2: adding runtime test, fixing comment

Author: anchuraj

flang/lib/Lower/OpenMP/OpenMP.cpp

@@ -1121,7 +1121,7 @@ genTargetOp(Fortran::lower::AbstractConverter &converter,
           eleType = refType.getElementType();
 
         // If a variable is specified in declare target link and if device
-        // type is nohost, it needs to be mapped tofrom
+        // type is not specified as `nohost`, it needs to be mapped tofrom
         mlir::ModuleOp mod = converter.getFirOpBuilder().getModule();
         mlir::Operation *op = mod.lookupSymbol(converter.mangleName(sym));
         auto declareTargetOp =

openmp/libomptarget/test/offloading/fortran/declare-target-array-in-target-region.f90

@@ -11,23 +11,59 @@
 ! RUN: %libomptarget-compile-fortran-run-and-check-generic
 module test_0
     implicit none
-    INTEGER :: sp(10) = (/0,0,0,0,0,0,0,0,0,0/)
-    !$omp declare target link(sp)
+    INTEGER :: arr1(10) = (/0,0,0,0,0,0,0,0,0,0/)
+    INTEGER :: arr2(10) = (/0,0,0,0,0,0,0,0,0,0/)
+    !$omp declare target link(arr1) enter(arr2)
 end module test_0
 
-program main
+subroutine test_with_array_link_and_tofrom()
     use test_0
     integer :: i = 1
     integer :: j = 11
-!$omp target map(tofrom:sp, i, j)
+!$omp target map(tofrom:arr1, i, j)
     do while (i <= j)
-        sp(i) = i;
+        arr1(i) = i;
         i = i + 1
     end do
 !$omp end target
 
-PRINT *, sp(:)
+! CHECK: 1 2 3 4 5 6 7 8 9 10
+PRINT *, arr1(:)
+end subroutine test_with_array_link_and_tofrom
 
-end program
+subroutine test_with_array_link_only()
+use test_0
+integer :: i = 1
+integer :: j = 11
+!$omp target map(i, j)
+    do while (i <= j)
+        arr1(i) = i + 1;
+        i = i + 1
+    end do
+!$omp end target
 
-! CHECK: 1 2 3 4 5 6 7 8 9 10
+! CHECK: 2 3 4 5 6 7 8 9 10 11
+PRINT *, arr1(:)
+end subroutine test_with_array_link_only
+
+subroutine test_with_array_enter_only()
+use test_0
+integer :: i = 1
+integer :: j = 11
+!$omp target map(i, j)
+    do while (i <= j)
+        arr2(i) = i + 1;
+        i = i + 1
+    end do
+!$omp end target
+
+! CHECK: 0 0 0 0 0 0 0 0 0 0
+PRINT *, arr2(:)
+end subroutine test_with_array_enter_only
+
+
+program main
+call test_with_array_link_and_tofrom()
+call test_with_array_link_only()
+call test_with_array_enter_only()
+end program