refactor: address review

Author: PankajDwivedi-25

llvm/lib/Target/AMDGPU/AMDGPUUniformIntrinsicCombine.cpp

@@ -104,22 +104,21 @@ static bool optimizeUniformIntrinsic(IntrinsicInst &II,
 static bool runUniformIntrinsicCombine(Function &F, const UniformityInfo *UI) {
   Module *M = F.getParent();
   // List of AMDGPU intrinsics to optimize if their arguments are uniform.
-  std::vector<Intrinsic::ID> Intrinsics = {
+  constexpr std::array<Intrinsic::ID, 4> Intrinsics = {
       Intrinsic::amdgcn_permlane64, Intrinsic::amdgcn_readfirstlane,
       Intrinsic::amdgcn_readlane, Intrinsic::amdgcn_ballot};
 
   bool IsChanged = false;
   for (Function &Func : M->functions()) {
     // Continue if intrinsic doesn't exists or not in the intrinsic list.
     Intrinsic::ID IID = Func.getIntrinsicID();
-    if (IID == Intrinsic::not_intrinsic || !llvm::is_contained(Intrinsics, IID))
+    if (!llvm::is_contained(Intrinsics, IID))
       continue;
 
     for (User *U : Func.users()) {
       if (auto *II = dyn_cast<IntrinsicInst>(U)) {
-        if (II->getFunction() == &F) {
+        if (II->getFunction() == &F)
           IsChanged |= optimizeUniformIntrinsic(*II, UI);
-        }
       }
     }
   }
@@ -135,6 +134,7 @@ class AMDGPUUniformIntrinsicCombineLegacy : public FunctionPass {
   }
   bool runOnFunction(Function &F) override;
   void getAnalysisUsage(AnalysisUsage &AU) const override {
+    AU.addRequired<UniformityInfoWrapperPass>();
     AU.addPreserved<UniformityInfoWrapperPass>();
   }
 };