Skip to content

Commit 18225c7

Browse files
committed
[ARM] Use MCRegister in 2 functions in ARMTargetStreamer. NFC
1 parent f760db1 commit 18225c7

File tree

4 files changed

+23
-22
lines changed

4 files changed

+23
-22
lines changed

llvm/include/llvm/MC/MCStreamer.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,9 @@ class ARMTargetStreamer : public MCTargetStreamer {
144144
virtual void emitPersonality(const MCSymbol *Personality);
145145
virtual void emitPersonalityIndex(unsigned Index);
146146
virtual void emitHandlerData();
147-
virtual void emitSetFP(unsigned FpReg, unsigned SpReg,
147+
virtual void emitSetFP(MCRegister FpReg, MCRegister SpReg,
148148
int64_t Offset = 0);
149-
virtual void emitMovSP(unsigned Reg, int64_t Offset = 0);
149+
virtual void emitMovSP(MCRegister Reg, int64_t Offset = 0);
150150
virtual void emitPad(int64_t Offset);
151151
virtual void emitRegSave(const SmallVectorImpl<MCRegister> &RegList,
152152
bool isVector);

llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ class UnwindContext {
113113
Locs PersonalityLocs;
114114
Locs PersonalityIndexLocs;
115115
Locs HandlerDataLocs;
116-
int FPReg;
116+
MCRegister FPReg;
117117

118118
public:
119119
UnwindContext(MCAsmParser &P) : Parser(P), FPReg(ARM::SP) {}
@@ -132,8 +132,8 @@ class UnwindContext {
132132
void recordHandlerData(SMLoc L) { HandlerDataLocs.push_back(L); }
133133
void recordPersonalityIndex(SMLoc L) { PersonalityIndexLocs.push_back(L); }
134134

135-
void saveFPReg(int Reg) { FPReg = Reg; }
136-
int getFPReg() const { return FPReg; }
135+
void saveFPReg(MCRegister Reg) { FPReg = Reg; }
136+
MCRegister getFPReg() const { return FPReg; }
137137

138138
void emitFnStartLocNotes() const {
139139
for (const SMLoc &Loc : FnStartLocs)
@@ -12115,8 +12115,7 @@ bool ARMAsmParser::parseDirectiveSetFP(SMLoc L) {
1211512115
if (Parser.parseEOL())
1211612116
return true;
1211712117

12118-
getTargetStreamer().emitSetFP(static_cast<unsigned>(FPReg),
12119-
static_cast<unsigned>(SPReg), Offset);
12118+
getTargetStreamer().emitSetFP(FPReg, SPReg, Offset);
1212012119
return false;
1212112120
}
1212212121

llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,9 @@ class ARMTargetAsmStreamer : public ARMTargetStreamer {
8080
void emitPersonality(const MCSymbol *Personality) override;
8181
void emitPersonalityIndex(unsigned Index) override;
8282
void emitHandlerData() override;
83-
void emitSetFP(unsigned FpReg, unsigned SpReg, int64_t Offset = 0) override;
84-
void emitMovSP(unsigned Reg, int64_t Offset = 0) override;
83+
void emitSetFP(MCRegister FpReg, MCRegister SpReg,
84+
int64_t Offset = 0) override;
85+
void emitMovSP(MCRegister Reg, int64_t Offset = 0) override;
8586
void emitPad(int64_t Offset) override;
8687
void emitRegSave(const SmallVectorImpl<MCRegister> &RegList,
8788
bool isVector) override;
@@ -139,7 +140,7 @@ void ARMTargetAsmStreamer::emitPersonalityIndex(unsigned Index) {
139140

140141
void ARMTargetAsmStreamer::emitHandlerData() { OS << "\t.handlerdata\n"; }
141142

142-
void ARMTargetAsmStreamer::emitSetFP(unsigned FpReg, unsigned SpReg,
143+
void ARMTargetAsmStreamer::emitSetFP(MCRegister FpReg, MCRegister SpReg,
143144
int64_t Offset) {
144145
OS << "\t.setfp\t";
145146
InstPrinter.printRegName(OS, FpReg);
@@ -150,7 +151,7 @@ void ARMTargetAsmStreamer::emitSetFP(unsigned FpReg, unsigned SpReg,
150151
OS << '\n';
151152
}
152153

153-
void ARMTargetAsmStreamer::emitMovSP(unsigned Reg, int64_t Offset) {
154+
void ARMTargetAsmStreamer::emitMovSP(MCRegister Reg, int64_t Offset) {
154155
assert((Reg != ARM::SP && Reg != ARM::PC) &&
155156
"the operand of .movsp cannot be either sp or pc");
156157

@@ -401,8 +402,9 @@ class ARMTargetELFStreamer : public ARMTargetStreamer {
401402
void emitPersonality(const MCSymbol *Personality) override;
402403
void emitPersonalityIndex(unsigned Index) override;
403404
void emitHandlerData() override;
404-
void emitSetFP(unsigned FpReg, unsigned SpReg, int64_t Offset = 0) override;
405-
void emitMovSP(unsigned Reg, int64_t Offset = 0) override;
405+
void emitSetFP(MCRegister FpReg, MCRegister SpReg,
406+
int64_t Offset = 0) override;
407+
void emitMovSP(MCRegister Reg, int64_t Offset = 0) override;
406408
void emitPad(int64_t Offset) override;
407409
void emitRegSave(const SmallVectorImpl<MCRegister> &RegList,
408410
bool isVector) override;
@@ -469,8 +471,8 @@ class ARMELFStreamer : public MCELFStreamer {
469471
void emitPersonality(const MCSymbol *Per);
470472
void emitPersonalityIndex(unsigned index);
471473
void emitHandlerData();
472-
void emitSetFP(unsigned NewFpReg, unsigned NewSpReg, int64_t Offset = 0);
473-
void emitMovSP(unsigned Reg, int64_t Offset = 0);
474+
void emitSetFP(MCRegister NewFpReg, MCRegister NewSpReg, int64_t Offset = 0);
475+
void emitMovSP(MCRegister Reg, int64_t Offset = 0);
474476
void emitPad(int64_t Offset);
475477
void emitRegSave(const SmallVectorImpl<MCRegister> &RegList, bool isVector);
476478
void emitUnwindRaw(int64_t Offset, const SmallVectorImpl<uint8_t> &Opcodes);
@@ -721,7 +723,7 @@ class ARMELFStreamer : public MCELFStreamer {
721723
MCSymbol *FnStart;
722724
const MCSymbol *Personality;
723725
unsigned PersonalityIndex;
724-
unsigned FPReg; // Frame pointer register
726+
MCRegister FPReg; // Frame pointer register
725727
int64_t FPOffset; // Offset: (final frame pointer) - (initial $sp)
726728
int64_t SPOffset; // Offset: (final $sp) - (initial $sp)
727729
int64_t PendingOffset; // Offset: (final $sp) - (emitted $sp)
@@ -753,12 +755,12 @@ void ARMTargetELFStreamer::emitHandlerData() {
753755
getStreamer().emitHandlerData();
754756
}
755757

756-
void ARMTargetELFStreamer::emitSetFP(unsigned FpReg, unsigned SpReg,
758+
void ARMTargetELFStreamer::emitSetFP(MCRegister FpReg, MCRegister SpReg,
757759
int64_t Offset) {
758760
getStreamer().emitSetFP(FpReg, SpReg, Offset);
759761
}
760762

761-
void ARMTargetELFStreamer::emitMovSP(unsigned Reg, int64_t Offset) {
763+
void ARMTargetELFStreamer::emitMovSP(MCRegister Reg, int64_t Offset) {
762764
getStreamer().emitMovSP(Reg, Offset);
763765
}
764766

@@ -1373,7 +1375,7 @@ void ARMELFStreamer::emitPersonalityIndex(unsigned Index) {
13731375
PersonalityIndex = Index;
13741376
}
13751377

1376-
void ARMELFStreamer::emitSetFP(unsigned NewFPReg, unsigned NewSPReg,
1378+
void ARMELFStreamer::emitSetFP(MCRegister NewFPReg, MCRegister NewSPReg,
13771379
int64_t Offset) {
13781380
assert((NewSPReg == ARM::SP || NewSPReg == FPReg) &&
13791381
"the operand of .setfp directive should be either $sp or $fp");
@@ -1387,7 +1389,7 @@ void ARMELFStreamer::emitSetFP(unsigned NewFPReg, unsigned NewSPReg,
13871389
FPOffset += Offset;
13881390
}
13891391

1390-
void ARMELFStreamer::emitMovSP(unsigned Reg, int64_t Offset) {
1392+
void ARMELFStreamer::emitMovSP(MCRegister Reg, int64_t Offset) {
13911393
assert((Reg != ARM::SP && Reg != ARM::PC) &&
13921394
"the operand of .movsp cannot be either sp or pc");
13931395
assert(FPReg == ARM::SP && "current FP must be SP");

llvm/lib/Target/ARM/MCTargetDesc/ARMTargetStreamer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ void ARMTargetStreamer::emitCantUnwind() {}
9292
void ARMTargetStreamer::emitPersonality(const MCSymbol *Personality) {}
9393
void ARMTargetStreamer::emitPersonalityIndex(unsigned Index) {}
9494
void ARMTargetStreamer::emitHandlerData() {}
95-
void ARMTargetStreamer::emitSetFP(unsigned FpReg, unsigned SpReg,
95+
void ARMTargetStreamer::emitSetFP(MCRegister FpReg, MCRegister SpReg,
9696
int64_t Offset) {}
97-
void ARMTargetStreamer::emitMovSP(unsigned Reg, int64_t Offset) {}
97+
void ARMTargetStreamer::emitMovSP(MCRegister Reg, int64_t Offset) {}
9898
void ARMTargetStreamer::emitPad(int64_t Offset) {}
9999
void ARMTargetStreamer::emitRegSave(const SmallVectorImpl<MCRegister> &RegList,
100100
bool isVector) {}

0 commit comments

Comments
 (0)