Skip to content

Commit 18d0666

Browse files
committed
Add a link to the specification to explain that i is not an extension
1 parent 1b533c0 commit 18d0666

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

llvm/lib/Support/RISCVISAInfo.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,10 @@ std::vector<std::string> RISCVISAInfo::toFeatures(bool AddAllExtensions,
470470
bool IgnoreUnknown) const {
471471
std::vector<std::string> Features;
472472
for (const auto &[ExtName, _] : Exts) {
473-
if (ExtName == "i") // i is not recognized in clang -cc1
473+
// i is a base instruction set, not an extension (see
474+
// https://github.com/riscv/riscv-isa-manual/blob/main/src/naming.adoc#base-integer-isa)
475+
// and is not recognized in clang -cc1
476+
if (ExtName == "i")
474477
continue;
475478
if (IgnoreUnknown && !isSupportedExtension(ExtName))
476479
continue;

0 commit comments

Comments
 (0)