Skip to content

Commit 19294b8

Browse files
Fix trivial review comments
Replace some (void)invalid with [[maybe_unused]]. Remove unused include.
1 parent 13888fd commit 19294b8

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

clang/lib/Driver/ToolChains/Flang.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
109
#include "Flang.h"
1110
#include "CommonArgs.h"
1211

@@ -170,7 +169,6 @@ void Flang::addPicOptions(const ArgList &Args, ArgStringList &CmdArgs) const {
170169
}
171170
}
172171

173-
174172
void Flang::AddAArch64TargetArgs(const ArgList &Args,
175173
ArgStringList &CmdArgs) const {
176174
// Handle -msve_vector_bits=<bits>
@@ -185,17 +183,17 @@ void Flang::AddAArch64TargetArgs(const ArgList &Args,
185183
if (Val.endswith("+"))
186184
Val = Val.substr(0, Val.size() - 1);
187185
else {
188-
bool Invalid = Val.getAsInteger(10, Bits); (void)Invalid;
186+
[[maybe_unused]] bool Invalid = Val.getAsInteger(10, Bits);
189187
assert(!Invalid && "Failed to parse value");
190188
CmdArgs.push_back(
191189
Args.MakeArgString("-mvscale-max=" + llvm::Twine(Bits / 128)));
192190
}
193191

194-
bool Invalid = Val.getAsInteger(10, Bits); (void)Invalid;
192+
[[maybe_unused]] bool Invalid = Val.getAsInteger(10, Bits);
195193
assert(!Invalid && "Failed to parse value");
196194
CmdArgs.push_back(
197195
Args.MakeArgString("-mvscale-min=" + llvm::Twine(Bits / 128)));
198-
// Silently drop requests for vector-length agnostic code as it's implied.
196+
// Silently drop requests for vector-length agnostic code as it's implied.
199197
} else if (!Val.equals("scalable"))
200198
// Handle the unsupported values passed to msve-vector-bits.
201199
D.Diag(diag::err_drv_unsupported_option_argument)

flang/lib/Frontend/FrontendActions.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
#include "mlir/Target/LLVMIR/ModuleTranslation.h"
4343
#include "clang/Basic/Diagnostic.h"
4444
#include "clang/Basic/DiagnosticFrontend.h"
45-
#include "clang/Basic/TargetInfo.h"
4645
#include "clang/Driver/DriverDiagnostic.h"
4746
#include "llvm/ADT/SmallString.h"
4847
#include "llvm/ADT/StringRef.h"

0 commit comments

Comments
 (0)