Skip to content

Commit 193f8ac

Browse files
committed
Fix formatting, use defaultdict
1 parent cf6e444 commit 193f8ac

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

lldb/packages/Python/lldbsuite/test/dotest.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -669,9 +669,7 @@ def iter_filters():
669669
# Add the entire file's worth of tests since we're not filtered.
670670
# Also the fail-over case when the filterspec branch
671671
# (base, filterspec) combo doesn't make sense.
672-
configuration.suite.addTests(
673-
unittest.defaultTestLoader.loadTestsFromName(base)
674-
)
672+
configuration.suite.addTests(unittest.defaultTestLoader.loadTestsFromName(base))
675673

676674

677675
def visit(prefix, dir, names):

lldb/test/API/lldbtest.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import collections
12
import os
23
import re
34
import operator
@@ -108,19 +109,20 @@ def execute(self, test, litConfig):
108109
return lit.Test.UNRESOLVED, output
109110

110111
details = results.group(1)
111-
parsed_details = {}
112+
parsed_details = collections.defaultdict(int)
112113
if details:
113114
for detail in details.split(", "):
114115
detail_parts = detail.split("=")
115116
if len(detail_parts) != 2:
116117
return lit.Test.UNRESOLVED, output
117118
parsed_details[detail_parts[0]] = int(detail_parts[1])
118119

119-
failures = parsed_details.get("failures", 0)
120-
errors = parsed_details.get("errors", 0)
121-
skipped = parsed_details.get("skipped", 0)
122-
expected_failures = parsed_details.get("expected failures", 0)
123-
unexpected_successes = parsed_details.get("unexpected successes", 0)
120+
failures = parsed_details["failures"]
121+
errors = parsed_details["errors"]
122+
skipped = parsed_details["skipped"]
123+
expected_failures = parsed_details["expected failures"]
124+
unexpected_successes = parsed_details["unexpected successes"]
125+
124126
non_pass = (
125127
failures + errors + skipped + expected_failures + unexpected_successes
126128
)

0 commit comments

Comments
 (0)