Address review feedback

Author: tbaederr

clang/lib/AST/Interp/ByteCodeExprGen.cpp

@@ -3348,8 +3348,7 @@ bool ByteCodeExprGen<Emitter>::VisitCallExpr(const CallExpr *E) {
         return false;
       if (!this->emitGetMemberPtrBase(E))
         return false;
-    } else {
-      if (!this->visit(MC->getImplicitObjectArgument()))
+    } else if (!this->visit(MC->getImplicitObjectArgument())) {
         return false;
     }
   }

clang/lib/AST/Interp/MemberPointer.h

@@ -34,6 +34,7 @@ class MemberPointer final {
   MemberPointer(uint32_t Address, const Descriptor *D) {
     // This should be impossible to hit, at least I've been unable
     // to write a test for it.
+    assert(false && "This constructor shouldn't be reachable for MemberPointers");
   }
 
   MemberPointer(const Decl *D) : Dcl(D) {
@@ -42,8 +43,7 @@ class MemberPointer final {
   }
 
   uint64_t getIntegerRepresentation() const {
-    // This should be impossible to hit, at least I've been unable
-    // to write a test for it.
+    assert(false && "getIntegerRepresentation() shouldn't be reachable for MemberPointers");
     return 17;
   }