Skip to content

Commit 19bd2d6

Browse files
kshitijvpkshitijvp
authored
[ConstantFolding] Add ilogb in isMathLibCallNoop (#122582)
ilogb libcall was not being constant folded correctly. This patch adds ilogb case in isMathLibCallNoop with correct error condition. Fixes #101873
1 parent 3606876 commit 19bd2d6

File tree

2 files changed

+216
-0
lines changed

2 files changed

+216
-0
lines changed

‎llvm/lib/Analysis/ConstantFolding.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3940,6 +3940,9 @@ bool llvm::isMathLibCallNoop(const CallBase *Call,
39403940
case LibFunc_log10f:
39413941
return Op.isNaN() || (!Op.isZero() && !Op.isNegative());
39423942

3943+
case LibFunc_ilogb:
3944+
return !Op.isNaN() && !Op.isZero() && !Op.isInfinity();
3945+
39433946
case LibFunc_expl:
39443947
case LibFunc_exp:
39453948
case LibFunc_expf:

‎llvm/test/Transforms/InstSimplify/pr122582.ll

Lines changed: 213 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
2+
; RUN: opt < %s -passes=instsimplify -S | FileCheck %s
3+
4+
define i32 @ilogbf_const1() {
5+
; CHECK-LABEL: define i32 @ilogbf_const1() {
6+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 7.000000e+00)
7+
; CHECK-NEXT: ret i32 2
8+
;
9+
%r = call i32 @ilogbf(float 7.000000e+00)
10+
ret i32 %r
11+
}
12+
13+
define i32 @ilogb_const1() {
14+
; CHECK-LABEL: define i32 @ilogb_const1() {
15+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -7.000000e+00)
16+
; CHECK-NEXT: ret i32 2
17+
;
18+
%r = call i32 @ilogb(double -7.000000e+00)
19+
ret i32 %r
20+
}
21+
22+
define i32 @ilogbf_const2() {
23+
; CHECK-LABEL: define i32 @ilogbf_const2() {
24+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 5.000000e-01)
25+
; CHECK-NEXT: ret i32 -1
26+
;
27+
%r = call i32 @ilogbf(float 5.000000e-01)
28+
ret i32 %r
29+
}
30+
31+
define i32 @ilogb_const2() {
32+
; CHECK-LABEL: define i32 @ilogb_const2() {
33+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -5.000000e-01)
34+
; CHECK-NEXT: ret i32 -1
35+
;
36+
%r = call i32 @ilogb(double -5.000000e-01)
37+
ret i32 %r
38+
}
39+
40+
define i32 @ilogbf_zero() {
41+
; CHECK-LABEL: define i32 @ilogbf_zero() {
42+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0.000000e+00)
43+
; CHECK-NEXT: ret i32 [[R]]
44+
;
45+
%r = call i32 @ilogbf(float 0.000000e+00)
46+
ret i32 %r
47+
}
48+
49+
define i32 @ilogb_zero() {
50+
; CHECK-LABEL: define i32 @ilogb_zero() {
51+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0.000000e+00)
52+
; CHECK-NEXT: ret i32 [[R]]
53+
;
54+
%r = call i32 @ilogb(double 0.000000e+00)
55+
ret i32 %r
56+
}
57+
58+
define i32 @ilogbf_neg_zero() {
59+
; CHECK-LABEL: define i32 @ilogbf_neg_zero() {
60+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float -0.000000e+00)
61+
; CHECK-NEXT: ret i32 [[R]]
62+
;
63+
%r = call i32 @ilogbf(float -0.000000e+00)
64+
ret i32 %r
65+
}
66+
67+
define i32 @ilogb_neg_zero() {
68+
; CHECK-LABEL: define i32 @ilogb_neg_zero() {
69+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -0.000000e+00)
70+
; CHECK-NEXT: ret i32 [[R]]
71+
;
72+
%r = call i32 @ilogb(double -0.000000e+00)
73+
ret i32 %r
74+
}
75+
76+
define i32 @ilogbf_inf() {
77+
; CHECK-LABEL: define i32 @ilogbf_inf() {
78+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF0000000000000)
79+
; CHECK-NEXT: ret i32 [[R]]
80+
;
81+
%r = call i32 @ilogbf(float 0x7FF0000000000000)
82+
ret i32 %r
83+
}
84+
85+
define i32 @ilogb_inf() {
86+
; CHECK-LABEL: define i32 @ilogb_inf() {
87+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF0000000000000)
88+
; CHECK-NEXT: ret i32 [[R]]
89+
;
90+
%r = call i32 @ilogb(double 0x7FF0000000000000)
91+
ret i32 %r
92+
}
93+
94+
define i32 @ilogbf_nan() {
95+
; CHECK-LABEL: define i32 @ilogbf_nan() {
96+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF8000000000000)
97+
; CHECK-NEXT: ret i32 [[R]]
98+
;
99+
%r = call i32 @ilogbf(float 0x7FF8000000000000)
100+
ret i32 %r
101+
}
102+
103+
define i32 @ilogb_nan() {
104+
; CHECK-LABEL: define i32 @ilogb_nan() {
105+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF8000000000000)
106+
; CHECK-NEXT: ret i32 [[R]]
107+
;
108+
%r = call i32 @ilogb(double 0x7FF8000000000000)
109+
ret i32 %r
110+
}
111+
112+
define i32 @ilogbf_zero_readnone() {
113+
; CHECK-LABEL: define i32 @ilogbf_zero_readnone() {
114+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0.000000e+00) #[[ATTR1:[0-9]+]]
115+
; CHECK-NEXT: ret i32 [[R]]
116+
;
117+
%r = call i32 @ilogbf(float 0.000000e+00) readnone
118+
ret i32 %r
119+
}
120+
121+
define i32 @ilogb_zero_readnone() {
122+
; CHECK-LABEL: define i32 @ilogb_zero_readnone() {
123+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0.000000e+00) #[[ATTR1]]
124+
; CHECK-NEXT: ret i32 [[R]]
125+
;
126+
%r = call i32 @ilogb(double 0.000000e+00) readnone
127+
ret i32 %r
128+
}
129+
130+
define i32 @ilogbf_neg_zero_readnone() {
131+
; CHECK-LABEL: define i32 @ilogbf_neg_zero_readnone() {
132+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float -0.000000e+00) #[[ATTR1]]
133+
; CHECK-NEXT: ret i32 [[R]]
134+
;
135+
%r = call i32 @ilogbf(float -0.000000e+00) readnone
136+
ret i32 %r
137+
}
138+
139+
define i32 @ilogb_neg_zero_readnone() {
140+
; CHECK-LABEL: define i32 @ilogb_neg_zero_readnone() {
141+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -0.000000e+00) #[[ATTR1]]
142+
; CHECK-NEXT: ret i32 [[R]]
143+
;
144+
%r = call i32 @ilogb(double -0.000000e+00) readnone
145+
ret i32 %r
146+
}
147+
148+
define i32 @ilogbf_inf_readnone() {
149+
; CHECK-LABEL: define i32 @ilogbf_inf_readnone() {
150+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF0000000000000) #[[ATTR1]]
151+
; CHECK-NEXT: ret i32 [[R]]
152+
;
153+
%r = call i32 @ilogbf(float 0x7FF0000000000000) readnone
154+
ret i32 %r
155+
}
156+
157+
define i32 @ilogb_inf_readnone() {
158+
; CHECK-LABEL: define i32 @ilogb_inf_readnone() {
159+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF0000000000000) #[[ATTR1]]
160+
; CHECK-NEXT: ret i32 [[R]]
161+
;
162+
%r = call i32 @ilogb(double 0x7FF0000000000000) readnone
163+
ret i32 %r
164+
}
165+
166+
define i32 @ilogbf_nan_readnone() {
167+
; CHECK-LABEL: define i32 @ilogbf_nan_readnone() {
168+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF8000000000000) #[[ATTR1]]
169+
; CHECK-NEXT: ret i32 [[R]]
170+
;
171+
%r = call i32 @ilogbf(float 0x7FF8000000000000) readnone
172+
ret i32 %r
173+
}
174+
175+
define i32 @ilogb_nan_readnone() {
176+
; CHECK-LABEL: define i32 @ilogb_nan_readnone() {
177+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF8000000000000) #[[ATTR1]]
178+
; CHECK-NEXT: ret i32 [[R]]
179+
;
180+
%r = call i32 @ilogb(double 0x7FF8000000000000) readnone
181+
ret i32 %r
182+
}
183+
184+
define i32 @ilogbf_poison() {
185+
; CHECK-LABEL: define i32 @ilogbf_poison() {
186+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float poison)
187+
; CHECK-NEXT: ret i32 [[R]]
188+
;
189+
%r = call i32 @ilogbf(float poison)
190+
ret i32 %r
191+
}
192+
193+
define i32 @ilogb_poison() {
194+
; CHECK-LABEL: define i32 @ilogb_poison() {
195+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double poison)
196+
; CHECK-NEXT: ret i32 [[R]]
197+
;
198+
%r = call i32 @ilogb(double poison)
199+
ret i32 %r
200+
}
201+
202+
define i32 @ilogb_const1_1() strictfp {
203+
; CHECK-LABEL: define i32 @ilogb_const1_1(
204+
; CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
205+
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -7.000000e+00)
206+
; CHECK-NEXT: ret i32 2
207+
;
208+
%r = call i32 @ilogb(double -7.000000e+00)
209+
ret i32 %r
210+
}
211+
212+
declare i32 @ilogbf(float)
213+
declare i32 @ilogb(double)

0 commit comments

Comments
 (0)