Skip to content

Commit 19e7846

Browse files
authored
[X86] Remove RAO-INT from Grandridge (#76420)
According to latest spec: https://cdrdv2.intel.com/v1/dl/getContent/671368
1 parent fdb8764 commit 19e7846

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

clang/test/Preprocessor/predefined-arch-macros.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2515,7 +2515,7 @@
25152515
// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_SRF_M32
25162516
// RUN: %clang -march=grandridge -m32 -E -dM %s -o - 2>&1 \
25172517
// RUN: --target=i386 \
2518-
// RUN: | FileCheck -match-full-lines %s -check-prefixes=CHECK_SRF_M32,CHECK_GRR_M32
2518+
// RUN: | FileCheck -match-full-lines %s -check-prefixes=CHECK_SRF_M32
25192519
// RUN: %clang -march=arrowlake -m32 -E -dM %s -o - 2>&1 \
25202520
// RUN: -target i386-unknown-linux \
25212521
// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_SRF_M32
@@ -2572,7 +2572,6 @@
25722572
// CHECK_SRF_M32: #define __PRFCHW__ 1
25732573
// CHECK_SRF_M32: #define __PTWRITE__ 1
25742574
// CHECK_SRF_M32-NOT: #define __RAOINT__ 1
2575-
// CHECK_GRR_M32: #define __RAOINT__ 1
25762575
// CHECK_SRF_M32: #define __RDPID__ 1
25772576
// CHECK_SRF_M32: #define __RDRND__ 1
25782577
// CHECK_SRF_M32: #define __RDSEED__ 1
@@ -2618,7 +2617,7 @@
26182617
// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_SRF_M64
26192618
// RUN: %clang -march=grandridge -m64 -E -dM %s -o - 2>&1 \
26202619
// RUN: --target=i386 \
2621-
// RUN: | FileCheck -match-full-lines %s -check-prefixes=CHECK_SRF_M64,CHECK_GRR_M64
2620+
// RUN: | FileCheck -match-full-lines %s -check-prefixes=CHECK_SRF_M64
26222621
// RUN: %clang -march=arrowlake -m64 -E -dM %s -o - 2>&1 \
26232622
// RUN: -target i386-unknown-linux \
26242623
// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_SRF_M64
@@ -2675,7 +2674,6 @@
26752674
// CHECK_SRF_M64: #define __PRFCHW__ 1
26762675
// CHECK_SRF_M64: #define __PTWRITE__ 1
26772676
// CHECK_SRF_M64-NOT: #define __RAOINT__ 1
2678-
// CHECK_GRR_M64: #define __RAOINT__ 1
26792677
// CHECK_SRF_M64: #define __RDPID__ 1
26802678
// CHECK_SRF_M64: #define __RDRND__ 1
26812679
// CHECK_SRF_M64: #define __RDSEED__ 1

llvm/lib/Target/X86/X86.td

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1256,11 +1256,6 @@ def ProcessorFeatures {
12561256
list<SubtargetFeature> SRFFeatures =
12571257
!listconcat(ADLFeatures, SRFAdditionalFeatures);
12581258

1259-
// Grandridge
1260-
list<SubtargetFeature> GRRAdditionalFeatures = [FeatureRAOINT];
1261-
list<SubtargetFeature> GRRFeatures =
1262-
!listconcat(SRFFeatures, GRRAdditionalFeatures);
1263-
12641259
// Arrowlake S
12651260
list<SubtargetFeature> ARLSAdditionalFeatures = [FeatureAVXVNNIINT16,
12661261
FeatureSHA512,
@@ -1706,10 +1701,10 @@ foreach P = ["goldmont_plus", "goldmont-plus"] in {
17061701
}
17071702
def : ProcModel<"tremont", SLMModel, ProcessorFeatures.TRMFeatures,
17081703
ProcessorFeatures.TRMTuning>;
1709-
def : ProcModel<"sierraforest", AlderlakePModel, ProcessorFeatures.SRFFeatures,
1710-
ProcessorFeatures.TRMTuning>;
1711-
def : ProcModel<"grandridge", AlderlakePModel, ProcessorFeatures.GRRFeatures,
1704+
foreach P = ["sierraforest", "grandridge"] in {
1705+
def : ProcModel<P, AlderlakePModel, ProcessorFeatures.SRFFeatures,
17121706
ProcessorFeatures.TRMTuning>;
1707+
}
17131708

17141709
// "Arrandale" along with corei3 and corei5
17151710
foreach P = ["nehalem", "corei7", "core_i7_sse4_2"] in {

llvm/lib/TargetParser/X86TargetParser.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,6 @@ constexpr FeatureBitset FeaturesAlderlake =
162162
constexpr FeatureBitset FeaturesSierraforest =
163163
FeaturesAlderlake | FeatureCMPCCXADD | FeatureAVXIFMA | FeatureUINTR |
164164
FeatureENQCMD | FeatureAVXNECONVERT | FeatureAVXVNNIINT8;
165-
constexpr FeatureBitset FeaturesGrandridge =
166-
FeaturesSierraforest | FeatureRAOINT;
167165
constexpr FeatureBitset FeaturesArrowlakeS = FeaturesSierraforest |
168166
FeatureAVXVNNIINT16 | FeatureSHA512 | FeatureSM3 | FeatureSM4;
169167
constexpr FeatureBitset FeaturesPantherlake =
@@ -369,7 +367,7 @@ constexpr ProcInfo Processors[] = {
369367
// Sierraforest microarchitecture based processors.
370368
{ {"sierraforest"}, CK_Sierraforest, FEATURE_AVX2, FeaturesSierraforest, 'p', false },
371369
// Grandridge microarchitecture based processors.
372-
{ {"grandridge"}, CK_Grandridge, FEATURE_AVX2, FeaturesGrandridge, 'p', false },
370+
{ {"grandridge"}, CK_Grandridge, FEATURE_AVX2, FeaturesSierraforest, 'p', false },
373371
// Granite Rapids microarchitecture based processors.
374372
{ {"graniterapids"}, CK_Graniterapids, FEATURE_AVX512BF16, FeaturesGraniteRapids, 'n', false },
375373
// Granite Rapids D microarchitecture based processors.

0 commit comments

Comments
 (0)