[libc] update LibcTableGenUtil for LLVM_LINK_LLVM_DYLIB

stephenneuendorffer · stephenneuendorffer · commit 1ab46e5cf86c · 2023-03-11T09:15:06.000-08:00
This library is linked into libc-hdrgen, which is compiled with DISABLE_LLVM_LINK_LLVM_DYLIB. This option avoids linking with libLLVM.so when LLVM_LINK_LLVM_DYLIB is specified. Unfortunately, this can cause wierd linkage errors where symbols are defined multiple times, with one definition coming from static linkage and another definition coming from libLLVM.so. This is usually apparent as a link error with options defined multiple times. This patch adds DISABLE_LLVM_LINK_LLVM_DYLIB to this library, to get consistent linkage of libc-hdrgen. Differential Revision: https://reviews.llvm.org/D145839
diff --git a/libc/utils/LibcTableGenUtil/CMakeLists.txt b/libc/utils/LibcTableGenUtil/CMakeLists.txt
@@ -2,6 +2,7 @@ add_llvm_library(
   LibcTableGenUtil
   APIIndexer.cpp
   APIIndexer.h
+  DISABLE_LLVM_LINK_LLVM_DYLIB
   LINK_COMPONENTS Support TableGen
 )
 target_include_directories(LibcTableGenUtil PUBLIC ${LIBC_SOURCE_DIR})

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ add_llvm_library(`
`2`	`2`	`LibcTableGenUtil`
`3`	`3`	`APIIndexer.cpp`
`4`	`4`	`APIIndexer.h`
	`5`	`+ DISABLE_LLVM_LINK_LLVM_DYLIB`
`5`	`6`	`LINK_COMPONENTS Support TableGen`
`6`	`7`	`)`
`7`	`8`	`target_include_directories(LibcTableGenUtil PUBLIC ${LIBC_SOURCE_DIR})`