[BOLT][NFC] Simplify successor check (#91980)

urnathan · web-flow · commit 1aff294f6ef9 · 2024-05-14T09:38:32.000-04:00
Remove excess parentheses and use `boolean ? true-case : false-case` idiom.
diff --git a/bolt/lib/Core/BinaryBasicBlock.cpp b/bolt/lib/Core/BinaryBasicBlock.cpp
@@ -131,11 +131,10 @@ bool BinaryBasicBlock::validateSuccessorInvariants() {
         break;
       }
       case 2:
-        Valid = (CondBranch &&
-                 (TBB == getConditionalSuccessor(true)->getLabel() &&
-                  ((!UncondBranch && !FBB) ||
-                   (UncondBranch &&
-                    FBB == getConditionalSuccessor(false)->getLabel()))));
+        Valid =
+            CondBranch && TBB == getConditionalSuccessor(true)->getLabel() &&
+            (UncondBranch ? FBB == getConditionalSuccessor(false)->getLabel()
+                          : !FBB);
         break;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -131,11 +131,10 @@ bool BinaryBasicBlock::validateSuccessorInvariants() {`
`131`	`131`	`break;`
`132`	`132`	`}`
`133`	`133`	`case 2:`
`134`		`- Valid = (CondBranch &&`
`135`		`- (TBB == getConditionalSuccessor(true)->getLabel() &&`
`136`		`- ((!UncondBranch && !FBB) \|\|`
`137`		`- (UncondBranch &&`
`138`		`- FBB == getConditionalSuccessor(false)->getLabel()))));`
	`134`	`+ Valid =`
	`135`	`+ CondBranch && TBB == getConditionalSuccessor(true)->getLabel() &&`
	`136`	`+ (UncondBranch ? FBB == getConditionalSuccessor(false)->getLabel()`
	`137`	`+ : !FBB);`
`139`	`138`	`break;`
`140`	`139`	`}`
`141`	`140`	`}`