Skip to content

Commit 1b6eddf

Browse files
use begin/end
1 parent b6a28eb commit 1b6eddf

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

mlir/include/mlir/Transforms/DialectConversion.h

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -906,9 +906,7 @@ class ConversionPatternRewriter final : public PatternRewriter {
906906
// Note: Prefer the ArrayRef<SmallVector<Value, 1>> overload because it
907907
// does not copy the replacements vector.
908908
auto vals = llvm::map_to_vector(newValues, [](const auto &r) {
909-
// Note: Create intermediate ValueRange because SmallVector<Value, 1>
910-
// is not constructible from SmallVector<Value>.
911-
return SmallVector<Value, 1>(ValueRange(r));
909+
return SmallVector<Value, 1>(std::begin(r), std::end(r));
912910
});
913911
replaceOpWithMultiple(op, ArrayRef(vals));
914912
}
@@ -919,9 +917,7 @@ class ConversionPatternRewriter final : public PatternRewriter {
919917
// Note: Prefer the ArrayRef<SmallVector<Value, 1>> overload because it
920918
// does not copy the replacements vector.
921919
auto vals = llvm::map_to_vector(newValues, [](const RangeT &r) {
922-
// Note: Create intermediate ValueRange because SmallVector<Value, 1>
923-
// is not constructible from SmallVector<Value>.
924-
return SmallVector<Value, 1>(ValueRange(r));
920+
return SmallVector<Value, 1>(std::begin(r), std::end(r));
925921
});
926922
replaceOpWithMultiple(op, ArrayRef(vals));
927923
}

0 commit comments

Comments
 (0)