Skip to content

Commit 1bc0b08

Browse files
committed
CMake: Fix LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING to be 1 or 0.
It has been introduced in #107278 but it was passing "DISABLED" of LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING to cmakedefine01. cmakadefine01 treats non-false-like strings as 1. "DISABLED" is replaced with 1.
1 parent 732ebf8 commit 1bc0b08

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

llvm/cmake/modules/HandleLLVMOptions.cmake

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,13 @@ elseif( uppercase_LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING STREQUAL "COVERAGE_AND_
204204
set( LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING 1 )
205205
set( LLVM_ENABLE_DEBUGLOC_ORIGIN_TRACKING 1 )
206206
elseif( uppercase_LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING STREQUAL "DISABLED" OR NOT DEFINED LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING )
207-
# The DISABLED setting is default and requires no additional defines.
207+
# The DISABLED setting is default.
208+
set( LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING 0 )
208209
else()
209210
message(FATAL_ERROR "Unknown value for LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING: \"${LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING}\"!")
210211
endif()
212+
# LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING (non-cached) is expected to be
213+
# 1 or 0 here, assuming referenced in #cmakedefine01.
211214

212215
if(LLVM_EXPERIMENTAL_KEY_INSTRUCTIONS)
213216
add_compile_definitions(EXPERIMENTAL_KEY_INSTRUCTIONS)

0 commit comments

Comments
 (0)