Skip to content

Commit 1bc2f1c

Browse files
[clang-tidy] Avoid repeated map lookups (NFC) (#127167)
1 parent 5be4536 commit 1bc2f1c

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,12 @@ void NonConstParameterCheck::addParm(const ParmVarDecl *Parm) {
119119
T->getPointeeType()->isFloatingType()))
120120
return;
121121

122-
if (Parameters.find(Parm) != Parameters.end())
122+
auto [It, Inserted] = Parameters.try_emplace(Parm);
123+
if (!Inserted)
123124
return;
124125

125-
ParmInfo PI;
126-
PI.IsReferenced = false;
127-
PI.CanBeConst = true;
128-
Parameters[Parm] = PI;
126+
It->second.IsReferenced = false;
127+
It->second.CanBeConst = true;
129128
}
130129

131130
void NonConstParameterCheck::setReferenced(const DeclRefExpr *Ref) {

0 commit comments

Comments
 (0)