Skip to content

Commit 1bf1e92

Browse files
[lldb] Avoid repeated map lookups (NFC) (#113121)
1 parent 61a286a commit 1bf1e92

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1295,12 +1295,11 @@ void SymbolFilePDB::CacheFunctionNames() {
12951295
continue;
12961296

12971297
if (CPlusPlusLanguage::IsCPPMangledName(name.c_str())) {
1298-
auto vm_addr = pub_sym_up->getVirtualAddress();
1299-
13001298
// PDB public symbol has mangled name for its associated function.
1301-
if (vm_addr && addr_ids.find(vm_addr) != addr_ids.end()) {
1302-
// Cache mangled name.
1303-
m_func_full_names.Append(ConstString(name), addr_ids[vm_addr]);
1299+
if (auto vm_addr = pub_sym_up->getVirtualAddress()) {
1300+
if (auto it = addr_ids.find(vm_addr); it != addr_ids.end())
1301+
// Cache mangled name.
1302+
m_func_full_names.Append(ConstString(name), it->second);
13041303
}
13051304
}
13061305
}

0 commit comments

Comments
 (0)