Skip to content

Commit 1c7e407

Browse files
committed
[lldb] Fix warning: 'sprintf' is deprecated in RNBSocketTest
Fixes warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.
1 parent 92ba7e3 commit 1c7e407

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

lldb/unittests/debugserver/RNBSocketTest.cpp

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ std::string goodbye = "Goodbye!";
2626
static void ServerCallbackv4(const void *baton, in_port_t port) {
2727
auto child_pid = fork();
2828
if (child_pid == 0) {
29-
char addr_buffer[256];
30-
sprintf(addr_buffer, "%s:%d", (const char *)baton, port);
29+
std::string addr_buffer =
30+
llvm::formatv("{0}:{1}", (const char *)baton, port).str();
3131
llvm::Expected<std::unique_ptr<Socket>> socket_or_err =
3232
Socket::TcpConnect(addr_buffer);
3333
ASSERT_THAT_EXPECTED(socket_or_err, llvm::Succeeded());
@@ -59,15 +59,12 @@ void TestSocketListen(const char *addr) {
5959
if (addresses.size() == 0)
6060
return;
6161

62-
char addr_wrap[256];
63-
if (addresses.front().GetFamily() == AF_INET6)
64-
sprintf(addr_wrap, "[%s]", addr);
65-
else
66-
sprintf(addr_wrap, "%s", addr);
62+
const char *fmt = addresses.front().GetFamily() == AF_INET6 ? "[{0}]" : "{0}";
63+
std::string addr_wrap = llvm::formatv(fmt, addr).str();
6764

6865
RNBSocket server_socket;
69-
auto result =
70-
server_socket.Listen(addr, 0, ServerCallbackv4, (const void *)addr_wrap);
66+
auto result = server_socket.Listen(addr, 0, ServerCallbackv4,
67+
(const void *)addr_wrap.c_str());
7168
ASSERT_TRUE(result == rnb_success);
7269
result = server_socket.Write(hello.c_str(), hello.length());
7370
ASSERT_TRUE(result == rnb_success);
@@ -94,11 +91,9 @@ void TestSocketConnect(const char *addr) {
9491
if (addresses.size() == 0)
9592
return;
9693

97-
char addr_wrap[256];
98-
if (addresses.front().GetFamily() == AF_INET6)
99-
sprintf(addr_wrap, "[%s]:0", addr);
100-
else
101-
sprintf(addr_wrap, "%s:0", addr);
94+
const char *fmt =
95+
addresses.front().GetFamily() == AF_INET6 ? "[{0}]:0" : "{0}:0";
96+
std::string addr_wrap = llvm::formatv(fmt, addr).str();
10297

10398
Socket *server_socket;
10499
llvm::Expected<std::unique_ptr<Socket>> socket_or_err =

0 commit comments

Comments
 (0)