Skip to content

Commit 1f0d24c

Browse files
committed
update_llc_test_checks: Fix broken amdgpu test
Use the correct address space for alloca. Also use opaque pointers.
1 parent 82b94a9 commit 1f0d24c

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_isel.ll

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
11
; RUN: llc -mtriple=amdgcn-amd-amdhsa -stop-after=finalize-isel -debug-only=isel -o /dev/null %s 2>&1 | FileCheck %s
22

33
define i64 @i64_test(i64 %i) nounwind readnone {
4-
%loc = alloca i64
5-
%j = load i64, i64 * %loc
4+
%loc = alloca i64, addrspace(5)
5+
%j = load i64, ptr addrspace(5) %loc
66
%r = add i64 %i, %j
77
ret i64 %r
88
}
99

1010
define i64 @i32_test(i32 %i) nounwind readnone {
11-
%loc = alloca i32
12-
%j = load i32, i32 * %loc
11+
%loc = alloca i32, addrspace(5)
12+
%j = load i32, ptr addrspace(5) %loc
1313
%r = add i32 %i, %j
1414
%ext = zext i32 %r to i64
1515
ret i64 %ext
1616
}
1717

1818
define i64 @i16_test(i16 %i) nounwind readnone {
19-
%loc = alloca i16
20-
%j = load i16, i16 * %loc
19+
%loc = alloca i16, addrspace(5)
20+
%j = load i16, ptr addrspace(5) %loc
2121
%r = add i16 %i, %j
2222
%ext = zext i16 %r to i64
2323
ret i64 %ext
2424
}
2525

2626
define i64 @i8_test(i8 %i) nounwind readnone {
27-
%loc = alloca i8
28-
%j = load i8, i8 * %loc
27+
%loc = alloca i8, addrspace(5)
28+
%j = load i8, ptr addrspace(5) %loc
2929
%r = add i8 %i, %j
3030
%ext = zext i8 %r to i64
3131
ret i64 %ext

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_isel.ll.expected

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ define i64 @i64_test(i64 %i) nounwind readnone {
1010
; CHECK-NEXT: t13: ch,glue = CopyToReg t11, Register:i32 $vgpr1, t17, t11:1
1111
; CHECK-NEXT: t14: ch = SI_RETURN Register:i32 $vgpr0, Register:i32 $vgpr1, t13, t13:1
1212
; CHECK-EMPTY:
13-
%loc = alloca i64
14-
%j = load i64, i64 * %loc
13+
%loc = alloca i64, addrspace(5)
14+
%j = load i64, ptr addrspace(5) %loc
1515
%r = add i64 %i, %j
1616
ret i64 %r
1717
}
@@ -25,8 +25,8 @@ define i64 @i32_test(i32 %i) nounwind readnone {
2525
; CHECK-NEXT: t9: ch,glue = CopyToReg t7, Register:i32 $vgpr1, t5, t7:1
2626
; CHECK-NEXT: t10: ch = SI_RETURN Register:i32 $vgpr0, Register:i32 $vgpr1, t9, t9:1
2727
; CHECK-EMPTY:
28-
%loc = alloca i32
29-
%j = load i32, i32 * %loc
28+
%loc = alloca i32, addrspace(5)
29+
%j = load i32, ptr addrspace(5) %loc
3030
%r = add i32 %i, %j
3131
%ext = zext i32 %r to i64
3232
ret i64 %ext
@@ -41,8 +41,8 @@ define i64 @i16_test(i16 %i) nounwind readnone {
4141
; CHECK-NEXT: t9: ch,glue = CopyToReg t7, Register:i32 $vgpr1, t5, t7:1
4242
; CHECK-NEXT: t10: ch = SI_RETURN Register:i32 $vgpr0, Register:i32 $vgpr1, t9, t9:1
4343
; CHECK-EMPTY:
44-
%loc = alloca i16
45-
%j = load i16, i16 * %loc
44+
%loc = alloca i16, addrspace(5)
45+
%j = load i16, ptr addrspace(5) %loc
4646
%r = add i16 %i, %j
4747
%ext = zext i16 %r to i64
4848
ret i64 %ext
@@ -57,8 +57,8 @@ define i64 @i8_test(i8 %i) nounwind readnone {
5757
; CHECK-NEXT: t9: ch,glue = CopyToReg t7, Register:i32 $vgpr1, t5, t7:1
5858
; CHECK-NEXT: t10: ch = SI_RETURN Register:i32 $vgpr0, Register:i32 $vgpr1, t9, t9:1
5959
; CHECK-EMPTY:
60-
%loc = alloca i8
61-
%j = load i8, i8 * %loc
60+
%loc = alloca i8, addrspace(5)
61+
%j = load i8, ptr addrspace(5) %loc
6262
%r = add i8 %i, %j
6363
%ext = zext i8 %r to i64
6464
ret i64 %ext

0 commit comments

Comments
 (0)