Skip to content

Commit 1f71db7

Browse files
authored
[NFC][DSE] Fix typo comment in eliminateDeadStores (#75166)
> We are re-using tryToMergePartialOverlappingStores, which requires DeadSI to dominate DeadSI. Should be "DeadSI to dominate KillingSI" because that's what the check is for.
1 parent 967e84e commit 1f71db7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2170,7 +2170,7 @@ static bool eliminateDeadStores(Function &F, AliasAnalysis &AA, MemorySSA &MSSA,
21702170
auto *DeadSI = dyn_cast<StoreInst>(DeadI);
21712171
auto *KillingSI = dyn_cast<StoreInst>(KillingI);
21722172
// We are re-using tryToMergePartialOverlappingStores, which requires
2173-
// DeadSI to dominate DeadSI.
2173+
// DeadSI to dominate KillingSI.
21742174
// TODO: implement tryToMergeParialOverlappingStores using MemorySSA.
21752175
if (DeadSI && KillingSI && DT.dominates(DeadSI, KillingSI)) {
21762176
if (Constant *Merged = tryToMergePartialOverlappingStores(

0 commit comments

Comments
 (0)