Skip to content

Commit 2252ae2

Browse files
[lldb] Override Should{Select,Show} in StopReasonBreakpoint
This is necessary so that LLDB does not select (or show the stop reason for) a thread which stopped at an internal breakpoint. Other than manual testing/inspection, which I've done, this does not seem to lend itself to API testing, as we cannot set internal breakpoints through the SBAPI.
1 parent fcf0f81 commit 2252ae2

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

lldb/source/Target/StopInfo.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,14 @@ class StopInfoBreakpoint : public StopInfo {
263263
return bp_site_sp->GetSuggestedStackFrameIndex();
264264
}
265265

266+
bool ShouldShow() const override {
267+
return !m_was_all_internal;
268+
}
269+
270+
bool ShouldSelect() const override {
271+
return !m_was_all_internal;
272+
}
273+
266274
protected:
267275
bool ShouldStop(Event *event_ptr) override {
268276
// This just reports the work done by PerformAction or the synchronous

0 commit comments

Comments
 (0)