Skip to content

Commit 2382de3

Browse files
committed
[AMDGPU] prevent shrinking udiv/urem if operands exceed smax_bitwidth
Do this by using ComputeKnownBits and checking for !isNonNegative and isUnsigned. This rejects shrinking unsigned div/rem if operands exceed smax_bitwidth since we know NumSignBits will be always 0.
1 parent e17c913 commit 2382de3

File tree

2 files changed

+69
-0
lines changed

2 files changed

+69
-0
lines changed

llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,6 +1193,18 @@ int AMDGPUCodeGenPrepareImpl::getDivNumBits(BinaryOperator &I, Value *Num,
11931193
Value *Den, unsigned AtLeast,
11941194
bool IsSigned) const {
11951195
const DataLayout &DL = Mod->getDataLayout();
1196+
if (!IsSigned) {
1197+
KnownBits Known = computeKnownBits(Num, DL, 0, AC, &I);
1198+
// We know all bits are used for division for Operand > smax_bitwidth
1199+
if (!Known.isNonNegative())
1200+
return -1;
1201+
1202+
Known = computeKnownBits(Den, DL, 0, AC, &I);
1203+
if (!Known.isNonNegative())
1204+
return -1;
1205+
}
1206+
1207+
11961208
unsigned LHSSignBits = ComputeNumSignBits(Num, DL, 0, AC, &I);
11971209
if (LHSSignBits < AtLeast)
11981210
return -1;

llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-idiv.ll

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9999,3 +9999,60 @@ define <2 x i64> @v_udiv_i64_exact(<2 x i64> %num) {
99999999
%result = udiv exact <2 x i64> %num, <i64 4096, i64 1024>
1000010000
ret <2 x i64> %result
1000110001
}
10002+
10003+
define i64 @udiv_i64_gt_smax(i8 %size) {
10004+
; GFX6-LABEL: udiv_i64_gt_smax:
10005+
; GFX6: ; %bb.0:
10006+
; GFX6-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
10007+
; GFX6-NEXT: v_bfe_i32 v0, v0, 0, 8
10008+
; GFX6-NEXT: v_ashrrev_i32_e32 v1, 31, v0
10009+
; GFX6-NEXT: v_not_b32_e32 v1, v1
10010+
; GFX6-NEXT: v_not_b32_e32 v0, v0
10011+
; GFX6-NEXT: s_mov_b32 s4, 0xcccccccd
10012+
; GFX6-NEXT: v_mul_lo_u32 v3, v1, s4
10013+
; GFX6-NEXT: v_mul_hi_u32 v4, v0, s4
10014+
; GFX6-NEXT: s_mov_b32 s6, 0xcccccccc
10015+
; GFX6-NEXT: v_mul_hi_u32 v5, v1, s4
10016+
; GFX6-NEXT: v_mul_hi_u32 v2, v0, s6
10017+
; GFX6-NEXT: v_mul_lo_u32 v0, v0, s6
10018+
; GFX6-NEXT: v_add_i32_e32 v3, vcc, v3, v4
10019+
; GFX6-NEXT: v_addc_u32_e32 v4, vcc, 0, v5, vcc
10020+
; GFX6-NEXT: v_add_i32_e32 v0, vcc, v0, v3
10021+
; GFX6-NEXT: v_addc_u32_e32 v0, vcc, 0, v2, vcc
10022+
; GFX6-NEXT: v_mul_lo_u32 v2, v1, s6
10023+
; GFX6-NEXT: v_mul_hi_u32 v1, v1, s6
10024+
; GFX6-NEXT: v_add_i32_e32 v0, vcc, v4, v0
10025+
; GFX6-NEXT: v_addc_u32_e64 v3, s[4:5], 0, 0, vcc
10026+
; GFX6-NEXT: v_add_i32_e32 v0, vcc, v2, v0
10027+
; GFX6-NEXT: v_addc_u32_e32 v1, vcc, v1, v3, vcc
10028+
; GFX6-NEXT: v_alignbit_b32 v0, v1, v0, 3
10029+
; GFX6-NEXT: v_lshrrev_b32_e32 v1, 3, v1
10030+
; GFX6-NEXT: s_setpc_b64 s[30:31]
10031+
;
10032+
; GFX9-LABEL: udiv_i64_gt_smax:
10033+
; GFX9: ; %bb.0:
10034+
; GFX9-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
10035+
; GFX9-NEXT: v_mov_b32_e32 v1, 31
10036+
; GFX9-NEXT: v_not_b32_sdwa v4, sext(v0) dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_0
10037+
; GFX9-NEXT: s_mov_b32 s4, 0xcccccccd
10038+
; GFX9-NEXT: v_ashrrev_i32_sdwa v1, v1, sext(v0) dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_0
10039+
; GFX9-NEXT: v_mul_hi_u32 v0, v4, s4
10040+
; GFX9-NEXT: v_not_b32_e32 v5, v1
10041+
; GFX9-NEXT: v_mov_b32_e32 v1, 0
10042+
; GFX9-NEXT: s_mov_b32 s6, 0xcccccccc
10043+
; GFX9-NEXT: v_mad_u64_u32 v[2:3], s[4:5], v5, s4, v[0:1]
10044+
; GFX9-NEXT: v_mov_b32_e32 v6, v3
10045+
; GFX9-NEXT: v_mov_b32_e32 v3, v1
10046+
; GFX9-NEXT: v_mad_u64_u32 v[0:1], s[4:5], v4, s6, v[2:3]
10047+
; GFX9-NEXT: v_mov_b32_e32 v0, v1
10048+
; GFX9-NEXT: v_add_co_u32_e32 v0, vcc, v6, v0
10049+
; GFX9-NEXT: v_addc_co_u32_e64 v1, s[4:5], 0, 0, vcc
10050+
; GFX9-NEXT: v_mad_u64_u32 v[0:1], s[4:5], v5, s6, v[0:1]
10051+
; GFX9-NEXT: v_alignbit_b32 v0, v1, v0, 3
10052+
; GFX9-NEXT: v_lshrrev_b32_e32 v1, 3, v1
10053+
; GFX9-NEXT: s_setpc_b64 s[30:31]
10054+
%esize = sext i8 %size to i64
10055+
%minus = sub nuw nsw i64 -1, %esize
10056+
%div = udiv i64 %minus, 10
10057+
ret i64 %div
10058+
}

0 commit comments

Comments
 (0)