Print more descriptive error message when trying to link a global with appending linkage

arrowd · arrowd · commit 255924cb7a36 · 2024-01-10T22:45:48.000+03:00
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -2910,7 +2910,7 @@ bool AsmPrinter::emitSpecialLLVMGlobal(const GlobalVariable *GV) {
     return true;
   }
 
-  report_fatal_error("unknown special variable");
+  report_fatal_error("unknown special variable with appending linkage");
 }
 
 /// EmitLLVMUsedList - For targets that define a MAI::UsedDirective, mark each
diff --git a/llvm/test/CodeGen/X86/AppendingLinkage.ll b/llvm/test/CodeGen/X86/AppendingLinkage.ll
@@ -1,4 +1,4 @@
 ; RUN: not --crash llc < %s -mtriple=i686-- 2>&1 | FileCheck %s
 
-; CHECK: unknown special variable
+; CHECK: unknown special variable with appending linkage
 @foo = appending constant [1 x i32 ]zeroinitializer

Original file line number	Diff line number	Diff line change
`@@ -2910,7 +2910,7 @@ bool AsmPrinter::emitSpecialLLVMGlobal(const GlobalVariable *GV) {`
`2910`	`2910`	`return true;`
`2911`	`2911`	`}`
`2912`	`2912`
`2913`		`- report_fatal_error("unknown special variable");`
	`2913`	`+ report_fatal_error("unknown special variable with appending linkage");`
`2914`	`2914`	`}`
`2915`	`2915`
`2916`	`2916`	`/// EmitLLVMUsedList - For targets that define a MAI::UsedDirective, mark each`