Fix truncated check lines; exclude bool

Author: mgehre-amd

mlir/lib/Conversion/ArithToEmitC/ArithToEmitC.cpp

@@ -69,6 +69,11 @@ class IntegerOpConversion final : public OpConversionPattern<ArithOp> {
       return rewriter.notifyMatchFailure(op, "expected integer type");
     }
 
+    if (type.isInteger(1)) {
+      // arith expects wrap-around arithmethic, which doesn't happen on `bool`.
+      return rewriter.notifyMatchFailure(op, "i1 type is not implemented");
+    }
+
     Value lhs = adaptor.getLhs();
     Value rhs = adaptor.getRhs();
     Type arithmeticType = type;

mlir/test/Conversion/ArithToEmitC/arith-to-emitc-failed.mlir

@@ -0,0 +1,15 @@
+// RUN: mlir-opt -convert-arith-to-emitc %s -split-input-file -verify-diagnostics
+
+func.func @bool(%arg0: i1, %arg1: i1) {
+  // expected-error@+1 {{failed to legalize operation 'arith.addi'}}
+  %0 = arith.addi %arg0, %arg1 : i1
+  return
+}
+
+// -----
+
+func.func @vector(%arg0: vector<4xi32>, %arg1: vector<4xi32>) {
+  // expected-error@+1 {{failed to legalize operation 'arith.addi'}}
+  %0 = arith.addi %arg0, %arg1 : vector<4xi32>
+  return
+}

mlir/test/Conversion/ArithToEmitC/arith-to-emitc.mlir

@@ -39,20 +39,20 @@ func.func @arith_ops(%arg0: f32, %arg1: f32) {
 
 // CHECK-LABEL: arith_integer_ops
 func.func @arith_integer_ops(%arg0: i32, %arg1: i32) {
-  // CHECK: %[[C1:[^ ]*]] = emitc.cast %arg0 : i32 to ui3
-  // CHECK: %[[C2:[^ ]*]] = emitc.cast %arg1 : i32 to ui3
+  // CHECK: %[[C1:[^ ]*]] = emitc.cast %arg0 : i32 to ui32
+  // CHECK: %[[C2:[^ ]*]] = emitc.cast %arg1 : i32 to ui32
   // CHECK: %[[ADD:[^ ]*]] = emitc.add %[[C1]], %[[C2]] : (ui32, ui32) -> ui32
-  // CHECK: %[[C3:[^ ]*]] = emitc.cast %[[ADD]] : ui32 to i3
+  // CHECK: %[[C3:[^ ]*]] = emitc.cast %[[ADD]] : ui32 to i32
   %0 = arith.addi %arg0, %arg1 : i32
-  // CHECK: %[[C1:[^ ]*]] = emitc.cast %arg0 : i32 to ui3
-  // CHECK: %[[C2:[^ ]*]] = emitc.cast %arg1 : i32 to ui3
+  // CHECK: %[[C1:[^ ]*]] = emitc.cast %arg0 : i32 to ui32
+  // CHECK: %[[C2:[^ ]*]] = emitc.cast %arg1 : i32 to ui32
   // CHECK: %[[SUB:[^ ]*]] = emitc.sub %[[C1]], %[[C2]] : (ui32, ui32) -> ui32
-  // CHECK: %[[C3:[^ ]*]] = emitc.cast %[[SUB]] : ui32 to i3
+  // CHECK: %[[C3:[^ ]*]] = emitc.cast %[[SUB]] : ui32 to i32
   %1 = arith.subi %arg0, %arg1 : i32
-  // CHECK: %[[C1:[^ ]*]] = emitc.cast %arg0 : i32 to ui3
-  // CHECK: %[[C2:[^ ]*]] = emitc.cast %arg1 : i32 to ui3
+  // CHECK: %[[C1:[^ ]*]] = emitc.cast %arg0 : i32 to ui32
+  // CHECK: %[[C2:[^ ]*]] = emitc.cast %arg1 : i32 to ui32
   // CHECK: %[[MUL:[^ ]*]] = emitc.mul %[[C1]], %[[C2]] : (ui32, ui32) -> ui32
-  // CHECK: %[[C3:[^ ]*]] = emitc.cast %[[MUL]] : ui32 to i3
+  // CHECK: %[[C3:[^ ]*]] = emitc.cast %[[MUL]] : ui32 to i32
   %2 = arith.muli %arg0, %arg1 : i32
 
   return