[Analysis] Remove unnecessary casts (NFC) (#146216)

kazutakahirata · web-flow · commit 25d7fd35b203 · 2025-06-28T13:03:31.000-07:00
PImpl is already of LazyValueInfoImpl *.
diff --git a/llvm/lib/Analysis/LazyValueInfo.cpp b/llvm/lib/Analysis/LazyValueInfo.cpp
@@ -1745,14 +1745,10 @@ LazyValueInfoImpl &LazyValueInfo::getOrCreateImpl(const Module *M) {
         Intrinsic::getDeclarationIfExists(M, Intrinsic::experimental_guard);
     PImpl = new LazyValueInfoImpl(AC, DL, GuardDecl);
   }
-  return *static_cast<LazyValueInfoImpl *>(PImpl);
+  return *PImpl;
 }
 
-LazyValueInfoImpl *LazyValueInfo::getImpl() {
-  if (!PImpl)
-    return nullptr;
-  return static_cast<LazyValueInfoImpl *>(PImpl);
-}
+LazyValueInfoImpl *LazyValueInfo::getImpl() { return PImpl; }
 
 LazyValueInfo::~LazyValueInfo() { releaseMemory(); }
 

Original file line number	Diff line number	Diff line change
`@@ -1745,14 +1745,10 @@ LazyValueInfoImpl &LazyValueInfo::getOrCreateImpl(const Module *M) {`
`1745`	`1745`	`Intrinsic::getDeclarationIfExists(M, Intrinsic::experimental_guard);`
`1746`	`1746`	`PImpl = new LazyValueInfoImpl(AC, DL, GuardDecl);`
`1747`	`1747`	`}`
`1748`		`- return static_cast<LazyValueInfoImpl >(PImpl);`
	`1748`	`+ return *PImpl;`
`1749`	`1749`	`}`
`1750`	`1750`
`1751`		`-LazyValueInfoImpl *LazyValueInfo::getImpl() {`
`1752`		`- if (!PImpl)`
`1753`		`- return nullptr;`
`1754`		`- return static_cast<LazyValueInfoImpl *>(PImpl);`
`1755`		`-}`
	`1751`	`+LazyValueInfoImpl *LazyValueInfo::getImpl() { return PImpl; }`
`1756`	`1752`
`1757`	`1753`	`LazyValueInfo::~LazyValueInfo() { releaseMemory(); }`
`1758`	`1754`