Add type records to TPI stream.

I don't think the data I add to a TPI stream in this patch is correct,
but at least it can be displayed using llvm-pdbdump. Until I add more
streams to a PDB file, I'm not able to know whether the data will be
accepted by MSVC tools or not.

llvm-svn: 289183

Author: rui314

lld/COFF/PDB.cpp

@@ -60,20 +60,28 @@ static SectionChunk *findByName(std::vector<SectionChunk *> &Sections,
   return nullptr;
 }
 
-static void dumpDebugT(ScopedPrinter &W, ObjectFile *File) {
+static ArrayRef<uint8_t> getDebugT(ObjectFile *File) {
   SectionChunk *Sec = findByName(File->getDebugChunks(), ".debug$T");
   if (!Sec)
-    return;
+    return {};
 
   // First 4 bytes are section magic.
   ArrayRef<uint8_t> Data = Sec->getContents();
   if (Data.size() < 4)
     fatal(".debug$T too short");
   if (read32le(Data.data()) != COFF::DEBUG_SECTION_MAGIC)
     fatal(".debug$T has an invalid magic");
+  return Data.slice(4);
+}
+
+static void dumpDebugT(ScopedPrinter &W, ObjectFile *File) {
+  ArrayRef<uint8_t> Data = getDebugT(File);
+  if (Data.empty())
+    return;
 
+  msf::ByteStream Stream(Data);
   CVTypeDumper TypeDumper(&W, false);
-  if (auto EC = TypeDumper.dump(Data.slice(4)))
+  if (auto EC = TypeDumper.dump(Data))
     fatal(EC, "CVTypeDumper::dump failed");
 }
 
@@ -104,6 +112,23 @@ static void dumpCodeView(SymbolTable *Symtab) {
   }
 }
 
+static void addTypeInfo(SymbolTable *Symtab,
+                        pdb::TpiStreamBuilder &TpiBuilder) {
+  for (ObjectFile *File : Symtab->ObjectFiles) {
+    ArrayRef<uint8_t> Data = getDebugT(File);
+    if (Data.empty())
+      continue;
+
+    msf::ByteStream Stream(Data);
+    codeview::CVTypeArray Records;
+    msf::StreamReader Reader(Stream);
+    if (auto EC = Reader.readArray(Records, Reader.getLength()))
+      fatal(EC, "Reader.readArray failed");
+    for (const codeview::CVType &Rec : Records)
+      TpiBuilder.addTypeRecord(Rec);
+  }
+}
+
 // Creates a PDB file.
 void coff::createPDB(StringRef Path, SymbolTable *Symtab,
                      ArrayRef<uint8_t> SectionTable) {
@@ -137,6 +162,7 @@ void coff::createPDB(StringRef Path, SymbolTable *Symtab,
   // Add an empty TPI stream.
   auto &TpiBuilder = Builder.getTpiBuilder();
   TpiBuilder.setVersionHeader(pdb::PdbTpiV80);
+  addTypeInfo(Symtab, TpiBuilder);
 
   // Add an empty IPI stream.
   auto &IpiBuilder = Builder.getIpiBuilder();