Skip to content

Commit 275eab9

Browse files
authored
[LLDB]Fix test crash (#129921)
Use the `SubsystemRAII` to unregister the fake manager at end of tests (Should fix #129910)
1 parent da61b0d commit 275eab9

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

lldb/unittests/Core/TelemetryTest.cpp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8+
#include "lldb/Core/Telemetry.h"
9+
#include "TestingSupport/SubsystemRAII.h"
810
#include "lldb/Core/PluginInterface.h"
911
#include "lldb/Core/PluginManager.h"
10-
#include "lldb/Core/Telemetry.h"
1112
#include "llvm/ADT/StringRef.h"
1213
#include "llvm/Support/Error.h"
1314
#include "llvm/Telemetry/Telemetry.h"
@@ -77,8 +78,13 @@ class FakePlugin : public telemetry::TelemetryManager {
7778

7879
using namespace lldb_private::telemetry;
7980

81+
class TelemetryTest : public testing::Test {
82+
public:
83+
lldb_private::SubsystemRAII<lldb_private::FakePlugin> subsystems;
84+
};
85+
8086
#if LLVM_ENABLE_TELEMETRY
81-
#define TELEMETRY_TEST(suite, test) TEST(suite, test)
87+
#define TELEMETRY_TEST(suite, test) TEST_F(suite, test)
8288
#else
8389
#define TELEMETRY_TEST(suite, test) TEST(DISABLED_##suite, test)
8490
#endif

0 commit comments

Comments
 (0)