Skip to content

Commit 2894719

Browse files
authored
[lldb-dap] Updating naming and documentation to follow style guide. (#130202)
Updating the naming and adding documentation to better follow the style guide.
1 parent ed6bde9 commit 2894719

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

lldb/tools/lldb-dap/OutputRedirector.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Expected<int> OutputRedirector::GetWriteFileDescriptor() {
3838
return m_fd;
3939
}
4040

41-
Error OutputRedirector::RedirectTo(std::FILE *fileOverride,
41+
Error OutputRedirector::RedirectTo(std::FILE *file_override,
4242
std::function<void(StringRef)> callback) {
4343
assert(m_fd == kInvalidDescriptor && "Output readirector already started.");
4444
int new_fd[2];
@@ -56,8 +56,8 @@ Error OutputRedirector::RedirectTo(std::FILE *fileOverride,
5656
int read_fd = new_fd[0];
5757
m_fd = new_fd[1];
5858

59-
if (fileOverride) {
60-
int override_fd = fileno(fileOverride);
59+
if (file_override) {
60+
int override_fd = fileno(file_override);
6161

6262
// Backup the FD to restore once redirection is complete.
6363
m_original_fd = override_fd;

lldb/tools/lldb-dap/OutputRedirector.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,16 @@ class OutputRedirector {
2424
/// Creates writable file descriptor that will invoke the given callback on
2525
/// each write in a background thread.
2626
///
27+
/// \param[in] file_override
28+
/// Updates the file descriptor to the redirection pipe, if not null.
29+
///
30+
/// \param[in] callback
31+
/// A callback invoked when any data is written to the file handle.
32+
///
2733
/// \return
2834
/// \a Error::success if the redirection was set up correctly, or an error
2935
/// otherwise.
30-
llvm::Error RedirectTo(std::FILE *overrideFile,
36+
llvm::Error RedirectTo(std::FILE *file_override,
3137
std::function<void(llvm::StringRef)> callback);
3238

3339
llvm::Expected<int> GetWriteFileDescriptor();

0 commit comments

Comments
 (0)