[LLDB][NFC] Fix possible resource leak

fixathon · fixathon · commit 2cfcbe295a31 · 2022-07-27T13:19:13.000-07:00
SymbolVendorPECOFF object is leaked on early return at line 110 Differential Revision: https://reviews.llvm.org/D130655
diff --git a/lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp b/lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp
@@ -102,8 +102,6 @@ SymbolVendorPECOFF::CreateInstance(const lldb::ModuleSP &module_sp,
   // This objfile is for debugging purposes.
   dsym_objfile_sp->SetType(ObjectFile::eTypeDebugInfo);
 
-  SymbolVendorPECOFF *symbol_vendor = new SymbolVendorPECOFF(module_sp);
-
   // Get the module unified section list and add our debug sections to
   // that.
   SectionList *module_section_list = module_sp->GetSectionList();
@@ -132,6 +130,7 @@ SymbolVendorPECOFF::CreateInstance(const lldb::ModuleSP &module_sp,
     }
   }
 
+  SymbolVendorPECOFF *symbol_vendor = new SymbolVendorPECOFF(module_sp);
   symbol_vendor->AddSymbolFileRepresentation(dsym_objfile_sp);
   return symbol_vendor;
 }

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,6 @@ SymbolVendorPECOFF::CreateInstance(const lldb::ModuleSP &module_sp,`
`102`	`102`	`// This objfile is for debugging purposes.`
`103`	`103`	`dsym_objfile_sp->SetType(ObjectFile::eTypeDebugInfo);`
`104`	`104`
`105`		`- SymbolVendorPECOFF *symbol_vendor = new SymbolVendorPECOFF(module_sp);`
`106`		`-`
`107`	`105`	`// Get the module unified section list and add our debug sections to`
`108`	`106`	`// that.`
`109`	`107`	`SectionList *module_section_list = module_sp->GetSectionList();`
`@@ -132,6 +130,7 @@ SymbolVendorPECOFF::CreateInstance(const lldb::ModuleSP &module_sp,`
`132`	`130`	`}`
`133`	`131`	`}`
`134`	`132`
	`133`	`+ SymbolVendorPECOFF *symbol_vendor = new SymbolVendorPECOFF(module_sp);`
`135`	`134`	`symbol_vendor->AddSymbolFileRepresentation(dsym_objfile_sp);`
`136`	`135`	`return symbol_vendor;`
`137`	`136`	`}`