Skip to content

Commit 2d0eb5d

Browse files
authored
[LLD][COFF] Add support for -includeglob on ARM64X (#129515)
Include symbols from both symbol tables.
1 parent 8f971ca commit 2d0eb5d

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lld/COFF/Driver.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2568,7 +2568,8 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
25682568

25692569
// Handle /includeglob
25702570
for (StringRef pat : args::getStrings(args, OPT_incl_glob))
2571-
ctx.symtab.addUndefinedGlob(pat);
2571+
ctx.forEachSymtab(
2572+
[&](SymbolTable &symtab) { symtab.addUndefinedGlob(pat); });
25722573

25732574
// Create wrapped symbols for -wrap option.
25742575
ctx.forEachSymtab([&](SymbolTable &symtab) {

lld/test/COFF/arm64x-includeoptional.s

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
// RUN: llvm-readobj --hex-dump=.test %t.dll | FileCheck %s
1212
// CHECK: 0x180004000 01000000 01000000
1313

14+
// RUN: lld-link -machine:arm64x -dll -noentry -out:%t-glob.dll %t-test.lib -includeglob:sym
15+
// RUN: llvm-readobj --hex-dump=.test %t-glob.dll | FileCheck %s
16+
1417
.globl sym
1518
.section .test,"dr"
1619
sym:

0 commit comments

Comments
 (0)