Skip to content

Commit 2df4be2

Browse files
authored
[Clang][NFC] Use std::move for Detail in timeTraceMetadata (#138352)
Static analysis flagged the use of Detail because we were not using std::move when returning values. Modified the returns to use std::move.
1 parent 15f7e02 commit 2df4be2

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

clang/lib/StaticAnalyzer/Core/CoreEngine.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,14 +199,15 @@ static llvm::TimeTraceMetadata timeTraceMetadata(const ExplodedNode *Pred,
199199
}
200200
auto SLoc = Loc.getSourceLocation();
201201
if (!SLoc)
202-
return llvm::TimeTraceMetadata{Detail, ""};
202+
return llvm::TimeTraceMetadata{std::move(Detail), ""};
203203
const auto &SM = Pred->getLocationContext()
204204
->getAnalysisDeclContext()
205205
->getASTContext()
206206
.getSourceManager();
207207
auto Line = SM.getPresumedLineNumber(*SLoc);
208208
auto Fname = SM.getFilename(*SLoc);
209-
return llvm::TimeTraceMetadata{Detail, Fname.str(), static_cast<int>(Line)};
209+
return llvm::TimeTraceMetadata{std::move(Detail), Fname.str(),
210+
static_cast<int>(Line)};
210211
}
211212

212213
void CoreEngine::dispatchWorkItem(ExplodedNode *Pred, ProgramPoint Loc,

0 commit comments

Comments
 (0)