Skip to content

Commit 2e0588d

Browse files
authored
Revert "[X86][AVX10.2] Support AVX10.2 option and VMPSADBW/VADDP[D,H,S] new instructions" (#101612)
Reverts #101452 There are several buildbot failed. Revert first.
1 parent 8abdf7c commit 2e0588d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+43
-1442
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,6 @@ X86 Support
216216
functions defined by the ``*mmintrin.h`` headers. A mapping can be
217217
found in the file ``clang/www/builtins.py``.
218218

219-
- Support ISA of ``AVX10.2``.
220-
221219
Arm and AArch64 Support
222220
^^^^^^^^^^^^^^^^^^^^^^^
223221

clang/include/clang/Basic/BuiltinsX86.def

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1959,14 +1959,6 @@ TARGET_HEADER_BUILTIN(__readgsword, "UsUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES,
19591959
TARGET_HEADER_BUILTIN(__readgsdword, "UNiUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, "")
19601960
TARGET_HEADER_BUILTIN(__readgsqword, "ULLiUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, "")
19611961

1962-
// AVX10.2 VMPSADBW
1963-
TARGET_BUILTIN(__builtin_ia32_mpsadbw512, "V32sV64cV64cIc", "ncV:512:", "avx10.2-512")
1964-
1965-
// AVX10.2 YMM Rounding
1966-
TARGET_BUILTIN(__builtin_ia32_vaddpd256_round, "V4dV4dV4dIi", "nV:256:", "avx10.2-256")
1967-
TARGET_BUILTIN(__builtin_ia32_vaddph256_round, "V16xV16xV16xIi", "nV:256:", "avx10.2-256")
1968-
TARGET_BUILTIN(__builtin_ia32_vaddps256_round, "V8fV8fV8fIi", "nV:256:", "avx10.2-256")
1969-
19701962
// AVX-VNNI-INT16
19711963
TARGET_BUILTIN(__builtin_ia32_vpdpwsud128, "V4iV4iV4iV4i", "nV:128:", "avxvnniint16")
19721964
TARGET_BUILTIN(__builtin_ia32_vpdpwsud256, "V8iV8iV8iV8i", "nV:256:", "avxvnniint16")

clang/include/clang/Driver/Options.td

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6205,12 +6205,6 @@ def mavx10_1_512 : Flag<["-"], "mavx10.1-512">, Group<m_x86_AVX10_Features_Group
62056205
def mno_avx10_1_512 : Flag<["-"], "mno-avx10.1-512">, Group<m_x86_AVX10_Features_Group>;
62066206
def mavx10_1 : Flag<["-"], "mavx10.1">, Alias<mavx10_1_256>;
62076207
def mno_avx10_1 : Flag<["-"], "mno-avx10.1">, Alias<mno_avx10_1_256>;
6208-
def mavx10_2_256 : Flag<["-"], "mavx10.2-256">, Group<m_x86_AVX10_Features_Group>;
6209-
def mno_avx10_2_256 : Flag<["-"], "mno-avx10.2-256">, Group<m_x86_AVX10_Features_Group>;
6210-
def mavx10_2_512 : Flag<["-"], "mavx10.2-512">, Group<m_x86_AVX10_Features_Group>;
6211-
def mno_avx10_2_512 : Flag<["-"], "mno-avx10.2-512">, Group<m_x86_AVX10_Features_Group>;
6212-
def mavx10_2 : Flag<["-"], "mavx10.2">, Alias<mavx10_2_256>;
6213-
def mno_avx10_2 : Flag<["-"], "mno-avx10.2">, Alias<mno_avx10_2_256>;
62146208
def mavx2 : Flag<["-"], "mavx2">, Group<m_x86_Features_Group>;
62156209
def mno_avx2 : Flag<["-"], "mno-avx2">, Group<m_x86_Features_Group>;
62166210
def mavx512f : Flag<["-"], "mavx512f">, Group<m_x86_Features_Group>;

clang/lib/Basic/Targets/X86.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -304,10 +304,6 @@ bool X86TargetInfo::handleTargetFeatures(std::vector<std::string> &Features,
304304
HasAVX10_1 = true;
305305
} else if (Feature == "+avx10.1-512") {
306306
HasAVX10_1_512 = true;
307-
} else if (Feature == "+avx10.2-256") {
308-
HasAVX10_2 = true;
309-
} else if (Feature == "+avx10.2-512") {
310-
HasAVX10_2_512 = true;
311307
} else if (Feature == "+avx512cd") {
312308
HasAVX512CD = true;
313309
} else if (Feature == "+avx512vpopcntdq") {
@@ -828,10 +824,6 @@ void X86TargetInfo::getTargetDefines(const LangOptions &Opts,
828824
Builder.defineMacro("__AVX10_1__");
829825
if (HasAVX10_1_512)
830826
Builder.defineMacro("__AVX10_1_512__");
831-
if (HasAVX10_2)
832-
Builder.defineMacro("__AVX10_2__");
833-
if (HasAVX10_2_512)
834-
Builder.defineMacro("__AVX10_2_512__");
835827
if (HasAVX512CD)
836828
Builder.defineMacro("__AVX512CD__");
837829
if (HasAVX512VPOPCNTDQ)
@@ -1064,8 +1056,6 @@ bool X86TargetInfo::isValidFeatureName(StringRef Name) const {
10641056
.Case("avx", true)
10651057
.Case("avx10.1-256", true)
10661058
.Case("avx10.1-512", true)
1067-
.Case("avx10.2-256", true)
1068-
.Case("avx10.2-512", true)
10691059
.Case("avx2", true)
10701060
.Case("avx512f", true)
10711061
.Case("avx512cd", true)
@@ -1181,8 +1171,6 @@ bool X86TargetInfo::hasFeature(StringRef Feature) const {
11811171
.Case("avx", SSELevel >= AVX)
11821172
.Case("avx10.1-256", HasAVX10_1)
11831173
.Case("avx10.1-512", HasAVX10_1_512)
1184-
.Case("avx10.2-256", HasAVX10_2)
1185-
.Case("avx10.2-512", HasAVX10_2_512)
11861174
.Case("avx2", SSELevel >= AVX2)
11871175
.Case("avx512f", SSELevel >= AVX512F)
11881176
.Case("avx512cd", HasAVX512CD)

clang/lib/Basic/Targets/X86.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,6 @@ class LLVM_LIBRARY_VISIBILITY X86TargetInfo : public TargetInfo {
9292
bool HasF16C = false;
9393
bool HasAVX10_1 = false;
9494
bool HasAVX10_1_512 = false;
95-
bool HasAVX10_2 = false;
96-
bool HasAVX10_2_512 = false;
9795
bool HasEVEX512 = false;
9896
bool HasAVX512CD = false;
9997
bool HasAVX512VPOPCNTDQ = false;

clang/lib/Driver/ToolChains/Arch/X86.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ void x86::getX86TargetFeatures(const Driver &D, const llvm::Triple &Triple,
241241
assert(Name.starts_with("avx10.") && "Invalid AVX10 feature name.");
242242
StringRef Version, Width;
243243
std::tie(Version, Width) = Name.substr(6).split('-');
244-
assert((Version == "1" || Version == "2") && "Invalid AVX10 feature name.");
244+
assert(Version == "1" && "Invalid AVX10 feature name.");
245245
assert((Width == "256" || Width == "512") && "Invalid AVX10 feature name.");
246246
#endif
247247

clang/lib/Headers/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,6 @@ set(x86_files
147147
amxcomplexintrin.h
148148
amxfp16intrin.h
149149
amxintrin.h
150-
avx10_2_512niintrin.h
151-
avx10_2niintrin.h
152150
avx2intrin.h
153151
avx512bf16intrin.h
154152
avx512bitalgintrin.h

clang/lib/Headers/avx10_2_512niintrin.h

Lines changed: 0 additions & 35 deletions
This file was deleted.

clang/lib/Headers/avx10_2niintrin.h

Lines changed: 0 additions & 83 deletions
This file was deleted.

clang/lib/Headers/immintrin.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -648,14 +648,6 @@ _storebe_i64(void * __P, long long __D) {
648648
#include <avx512vlvp2intersectintrin.h>
649649
#endif
650650

651-
#if !defined(__SCE__) || __has_feature(modules) || defined(__AVX10_2__)
652-
#include <avx10_2niintrin.h>
653-
#endif
654-
655-
#if !defined(__SCE__) || __has_feature(modules) || defined(__AVX10_2_512__)
656-
#include <avx10_2_512niintrin.h>
657-
#endif
658-
659651
#if !defined(__SCE__) || __has_feature(modules) || defined(__ENQCMD__)
660652
#include <enqcmdintrin.h>
661653
#endif

clang/lib/Sema/SemaX86.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,6 @@ bool SemaX86::CheckBuiltinRoundingOrSAE(unsigned BuiltinID, CallExpr *TheCall) {
162162
case X86::BI__builtin_ia32_mulps512:
163163
case X86::BI__builtin_ia32_subpd512:
164164
case X86::BI__builtin_ia32_subps512:
165-
case X86::BI__builtin_ia32_vaddpd256_round:
166-
case X86::BI__builtin_ia32_vaddph256_round:
167-
case X86::BI__builtin_ia32_vaddps256_round:
168165
case X86::BI__builtin_ia32_cvtsi2sd64:
169166
case X86::BI__builtin_ia32_cvtsi2ss32:
170167
case X86::BI__builtin_ia32_cvtsi2ss64:

clang/test/CodeGen/X86/avx10_2_512ni-builtins.c

Lines changed: 0 additions & 25 deletions
This file was deleted.

clang/test/CodeGen/X86/avx10_2ni-builtins.c

Lines changed: 0 additions & 106 deletions
This file was deleted.

0 commit comments

Comments
 (0)