Skip to content

Commit 30b9140

Browse files
committed
[RISCV] Minor cleanup to rori MC layer testing. NFC
rv32zbb-valid.s tests rv64 and rv32. rv32zbb-only-valid.s only tests rv32. The rori tests in rv32zbb-only-valid.s produce the same result for rv32 and rv64 so its better to test them in rv32zbb-valid.s. Remove a now redundant test case from rv64zbb-valid.s. Add a missing rori test with imm >= 32 to rv64zbkb-valid.s.
1 parent 235f1e7 commit 30b9140

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

llvm/test/MC/RISCV/rv32zbb-only-valid.s

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@
88
# CHECK-ASM-AND-OBJ: zext.h t0, t1
99
# CHECK-ASM: encoding: [0xb3,0x42,0x03,0x08]
1010
zext.h t0, t1
11-
# CHECK-ASM-AND-OBJ: rori t0, t1, 31
12-
# CHECK-ASM: encoding: [0x93,0x52,0xf3,0x61]
13-
rori t0, t1, 31
14-
# CHECK-ASM-AND-OBJ: rori t0, t1, 0
15-
# CHECK-ASM: encoding: [0x93,0x52,0x03,0x60]
16-
rori t0, t1, 0
1711
# CHECK-ASM-AND-OBJ: rev8 t0, t1
1812
# CHECK-ASM: encoding: [0x93,0x52,0x83,0x69]
1913
rev8 t0, t1

llvm/test/MC/RISCV/rv32zbb-valid.s

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
# RUN: llvm-mc %s -triple=riscv64 -mattr=+zbb -riscv-no-aliases -show-encoding \
55
# RUN: | FileCheck -check-prefixes=CHECK-ASM,CHECK-ASM-AND-OBJ %s
66
# RUN: llvm-mc -filetype=obj -triple=riscv32 -mattr=+zbb < %s \
7-
# RUN: | llvm-objdump --mattr=+zbb -M no-aliases -d -r - \
7+
# RUN: | llvm-objdump --mattr=+zbb --no-print-imm-hex -M no-aliases -d -r - \
88
# RUN: | FileCheck --check-prefix=CHECK-ASM-AND-OBJ %s
99
# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+zbb < %s \
10-
# RUN: | llvm-objdump --mattr=+zbb -M no-aliases -d -r - \
10+
# RUN: | llvm-objdump --mattr=+zbb --no-print-imm-hex -M no-aliases -d -r - \
1111
# RUN: | FileCheck --check-prefix=CHECK-ASM-AND-OBJ %s
1212

1313
# CHECK-ASM-AND-OBJ: clz t0, t1
@@ -55,6 +55,12 @@ rol t0, t1, t2
5555
# CHECK-ASM-AND-OBJ: ror t0, t1, t2
5656
# CHECK-ASM: encoding: [0xb3,0x52,0x73,0x60]
5757
ror t0, t1, t2
58+
# CHECK-ASM-AND-OBJ: rori t0, t1, 31
59+
# CHECK-ASM: encoding: [0x93,0x52,0xf3,0x61]
60+
rori t0, t1, 31
61+
# CHECK-ASM-AND-OBJ: rori t0, t1, 0
62+
# CHECK-ASM: encoding: [0x93,0x52,0x03,0x60]
63+
rori t0, t1, 0
5864
# CHECK-ASM-AND-OBJ: orc.b t0, t1
5965
# CHECK-ASM: encoding: [0x93,0x52,0x73,0x28]
6066
orc.b t0, t1

llvm/test/MC/RISCV/rv64zbb-valid.s

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ zext.h t0, t1
1111
# CHECK-ASM-AND-OBJ: rori t0, t1, 63
1212
# CHECK-ASM: encoding: [0x93,0x52,0xf3,0x63]
1313
rori t0, t1, 63
14-
# CHECK-ASM-AND-OBJ: rori t0, t1, 0
15-
# CHECK-ASM: encoding: [0x93,0x52,0x03,0x60]
16-
rori t0, t1, 0
1714
# CHECK-ASM-AND-OBJ: rev8 t0, t1
1815
# CHECK-ASM: encoding: [0x93,0x52,0x83,0x6b]
1916
rev8 t0, t1

llvm/test/MC/RISCV/rv64zbkb-valid.s

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88
# CHECK-ASM: encoding: [0x93,0x52,0x83,0x6b]
99
rev8 t0, t1
1010

11+
# CHECK-ASM-AND-OBJ: rori t0, t1, 63
12+
# CHECK-ASM: encoding: [0x93,0x52,0xf3,0x63]
13+
rori t0, t1, 63
1114
# CHECK-ASM-AND-OBJ: rorw t0, t1, t2
1215
# CHECK-ASM: encoding: [0xbb,0x52,0x73,0x60]
1316
rorw t0, t1, t2

0 commit comments

Comments
 (0)