Revert fixing up ExecutionFailed, remove the test for ExecutionFailed instead

Author: arsenm

llvm/lib/Support/Program.cpp

@@ -45,10 +45,6 @@ int sys::ExecuteAndWait(StringRef Program, ArrayRef<StringRef> Args,
     ProcessInfo Result = Wait(
         PI, SecondsToWait == 0 ? std::nullopt : std::optional(SecondsToWait),
         ErrMsg, ProcStat);
-
-    if (ExecutionFailed && Result.ReturnCode < 0)
-      *ExecutionFailed = true;
-
     return Result.ReturnCode;
   }
 

llvm/unittests/Support/ProgramTest.cpp

@@ -422,10 +422,13 @@ TEST(ProgramTest, TestExecuteNegative) {
     bool ExecutionFailed;
     int RetCode = ExecuteAndWait(Executable, argv, std::nullopt, {}, 0, 0,
                                  &Error, &ExecutionFailed);
+
     EXPECT_LT(RetCode, 0) << "On error ExecuteAndWait should return 0 or "
                              "positive value indicating the result code";
-    EXPECT_TRUE(ExecutionFailed);
     EXPECT_FALSE(Error.empty());
+
+    // Note ExecutionFailed may or may not be false. When using fork, the error
+    // is produced on the wait for the child, not the execution point.
   }
 
   {