Skip to content

Commit 3261fb1

Browse files
committed
Remove outdated comment, add a comment on max thunk name length
1 parent 84e7eb3 commit 3261fb1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

llvm/lib/Target/AArch64/AArch64SLSHardening.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,9 @@ bool SLSHardeningInserter::hardenReturnsAndBRs(MachineModuleInfo &MMI,
262262
return Modified;
263263
}
264264

265+
// Currently, the longest possible thunk name is
266+
// __llvm_slsblr_thunk_aa_xNN_xMM
267+
// which is 31 characters (without the '\0' character).
265268
static SmallString<32> createThunkName(const ThunkKind &Kind, Register Xn,
266269
Register Xm) {
267270
unsigned N = ThunksSet::indexOfXReg(Xn);
@@ -310,8 +313,6 @@ static const ThunkKind &parseThunkName(StringRef ThunkName, Register &Xn,
310313
void SLSHardeningInserter::populateThunk(MachineFunction &MF) {
311314
assert(MF.getFunction().hasComdat() == ComdatThunks &&
312315
"ComdatThunks value changed since MF creation");
313-
// FIXME: How to better communicate Register number, rather than through
314-
// name and lookup table?
315316
Register Xn, Xm;
316317
const ThunkKind &Kind = parseThunkName(MF.getName(), Xn, Xm);
317318

0 commit comments

Comments
 (0)