[clang] Marshallers.h - use move semantics for 'NodeKinds' and update possible callers to use it (#87273)

Amila-Rukshan · web-flow · commit 32623a3fc09a · 2024-04-20T10:47:57.000+01:00
Fixes: #87248 Signed-off-by: amila <amila.15@cse.mrt.ac.lk>
diff --git a/clang/lib/ASTMatchers/Dynamic/Marshallers.h b/clang/lib/ASTMatchers/Dynamic/Marshallers.h
@@ -937,7 +937,7 @@ class MapAnyOfMatcherDescriptor : public MatcherDescriptor {
 public:
   MapAnyOfMatcherDescriptor(ASTNodeKind CladeNodeKind,
                             std::vector<ASTNodeKind> NodeKinds)
-      : CladeNodeKind(CladeNodeKind), NodeKinds(NodeKinds) {}
+      : CladeNodeKind(CladeNodeKind), NodeKinds(std::move(NodeKinds)) {}
 
   VariantMatcher create(SourceRange NameRange, ArrayRef<ParserValue> Args,
                         Diagnostics *Error) const override {
@@ -1026,7 +1026,7 @@ class MapAnyOfBuilderDescriptor : public MatcherDescriptor {
     }
 
     return std::make_unique<MapAnyOfMatcherDescriptor>(CladeNodeKind,
-                                                       NodeKinds);
+                                                       std::move(NodeKinds));
   }
 
   bool isVariadic() const override { return true; }

Original file line number	Diff line number	Diff line change
`@@ -937,7 +937,7 @@ class MapAnyOfMatcherDescriptor : public MatcherDescriptor {`
`937`	`937`	`public:`
`938`	`938`	`MapAnyOfMatcherDescriptor(ASTNodeKind CladeNodeKind,`
`939`	`939`	`std::vector<ASTNodeKind> NodeKinds)`
`940`		`- : CladeNodeKind(CladeNodeKind), NodeKinds(NodeKinds) {}`
	`940`	`+ : CladeNodeKind(CladeNodeKind), NodeKinds(std::move(NodeKinds)) {}`
`941`	`941`
`942`	`942`	`VariantMatcher create(SourceRange NameRange, ArrayRef<ParserValue> Args,`
`943`	`943`	`Diagnostics *Error) const override {`
`@@ -1026,7 +1026,7 @@ class MapAnyOfBuilderDescriptor : public MatcherDescriptor {`
`1026`	`1026`	`}`
`1027`	`1027`
`1028`	`1028`	`return std::make_unique<MapAnyOfMatcherDescriptor>(CladeNodeKind,`
`1029`		`- NodeKinds);`
	`1029`	`+ std::move(NodeKinds));`
`1030`	`1030`	`}`
`1031`	`1031`
`1032`	`1032`	`bool isVariadic() const override { return true; }`