Skip to content

Commit 329d30a

Browse files
sunfishcodesunfishcode
committed
[WebAssembly] Support the new "Lime1" CPU
This adds WebAssembly support for the new [Lime1 CPU]. First, this defines some new target features. These are subsets of existing features that reflect implementation concerns: - "call-indirect-overlong" - implied by "reference-types"; just the overlong encoding for the `call_indirect` immediate, and not the actual reference types. - "bulk-memory-opt" - implied by "bulk-memory": just `memory.copy` and `memory.fill`, and not the other instructions in the bulk-memory proposal. Next, this defines a new target CPU, "lime1", which enables mutable-globals, bulk-memory-opt, multivalue, sign-ext, nontrapping-fptoint, extended-const, and call-indirect-overlong. Unlike the default "generic" CPU, "lime1" is meant to be frozen, and followed up by "lime2" and so on when new features are desired. [Lime1 CPU]: https://github.com/WebAssembly/tool-conventions/blob/main/Lime.md#lime1
1 parent 668f2c7 commit 329d30a

33 files changed

+216
-64
lines changed

‎clang/docs/ReleaseNotes.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -854,9 +854,15 @@ and `-mbulk-memory` flags, which correspond to the [Bulk Memory Operations]
854854
and [Non-trapping float-to-int Conversions] language features, which are
855855
[widely implemented in engines].
856856

857+
A new Lime1 target CPU is added, -mcpu=lime1. This CPU follows the definition of
858+
the Lime1 CPU [here], and enables -mmultivalue, -mmutable-globals,
859+
-mcall-indirect-overlong, -msign-ext, -mbulk-memory-opt, -mnontrapping-fptoint,
860+
and -mextended-const.
861+
857862
[Bulk Memory Operations]: https://github.com/WebAssembly/bulk-memory-operations/blob/master/proposals/bulk-memory-operations/Overview.md
858863
[Non-trapping float-to-int Conversions]: https://github.com/WebAssembly/spec/blob/master/proposals/nontrapping-float-to-int-conversion/Overview.md
859864
[widely implemented in engines]: https://webassembly.org/features/
865+
[here]: https://github.com/WebAssembly/tool-conventions/blob/main/Lime.md#lime1
860866

861867
AVR Support
862868
^^^^^^^^^^^

‎clang/lib/Basic/Targets/WebAssembly.cpp

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ bool WebAssemblyTargetInfo::hasFeature(StringRef Feature) const {
4747
return llvm::StringSwitch<bool>(Feature)
4848
.Case("atomics", HasAtomics)
4949
.Case("bulk-memory", HasBulkMemory)
50+
.Case("bulk-memory-opt", HasBulkMemoryOpt)
51+
.Case("call-indirect-overlong", HasCallIndirectOverlong)
5052
.Case("exception-handling", HasExceptionHandling)
5153
.Case("extended-const", HasExtendedConst)
5254
.Case("fp16", HasFP16)
@@ -79,6 +81,8 @@ void WebAssemblyTargetInfo::getTargetDefines(const LangOptions &Opts,
7981
Builder.defineMacro("__wasm_atomics__");
8082
if (HasBulkMemory)
8183
Builder.defineMacro("__wasm_bulk_memory__");
84+
if (HasBulkMemoryOpt)
85+
Builder.defineMacro("__wasm_bulk_memory_opt__");
8286
if (HasExceptionHandling)
8387
Builder.defineMacro("__wasm_exception_handling__");
8488
if (HasExtendedConst)
@@ -155,12 +159,24 @@ bool WebAssemblyTargetInfo::initFeatureMap(
155159
const std::vector<std::string> &FeaturesVec) const {
156160
auto addGenericFeatures = [&]() {
157161
Features["bulk-memory"] = true;
162+
Features["bulk-memory-opt"] = true;
163+
Features["call-indirect-overlong"] = true;
158164
Features["multivalue"] = true;
159165
Features["mutable-globals"] = true;
160166
Features["nontrapping-fptoint"] = true;
161167
Features["reference-types"] = true;
162168
Features["sign-ext"] = true;
163169
};
170+
auto addLime1Features = [&]() {
171+
// Lime1: <https://github.com/WebAssembly/tool-conventions/blob/main/Lime.md#lime1>
172+
Features["multivalue"] = true;
173+
Features["mutable-globals"] = true;
174+
Features["call-indirect-overlong"] = true;
175+
Features["sign-ext"] = true;
176+
Features["bulk-memory-opt"] = true;
177+
Features["nontrapping-fptoint"] = true;
178+
Features["extended-const"] = true;
179+
};
164180
auto addBleedingEdgeFeatures = [&]() {
165181
addGenericFeatures();
166182
Features["atomics"] = true;
@@ -174,6 +190,8 @@ bool WebAssemblyTargetInfo::initFeatureMap(
174190
};
175191
if (CPU == "generic") {
176192
addGenericFeatures();
193+
} else if (CPU == "lime1") {
194+
addLime1Features();
177195
} else if (CPU == "bleeding-edge") {
178196
addBleedingEdgeFeatures();
179197
}
@@ -200,6 +218,14 @@ bool WebAssemblyTargetInfo::handleTargetFeatures(
200218
HasBulkMemory = false;
201219
continue;
202220
}
221+
if (Feature == "+bulk-memory-opt") {
222+
HasBulkMemoryOpt = true;
223+
continue;
224+
}
225+
if (Feature == "-bulk-memory-opt") {
226+
HasBulkMemoryOpt = false;
227+
continue;
228+
}
203229
if (Feature == "+exception-handling") {
204230
HasExceptionHandling = true;
205231
continue;
@@ -265,6 +291,14 @@ bool WebAssemblyTargetInfo::handleTargetFeatures(
265291
HasReferenceTypes = false;
266292
continue;
267293
}
294+
if (Feature == "+call-indirect-overlong") {
295+
HasCallIndirectOverlong = true;
296+
continue;
297+
}
298+
if (Feature == "-call-indirect-overlong") {
299+
HasCallIndirectOverlong = false;
300+
continue;
301+
}
268302
if (Feature == "+relaxed-simd") {
269303
SIMDLevel = std::max(SIMDLevel, RelaxedSIMD);
270304
continue;
@@ -310,6 +344,18 @@ bool WebAssemblyTargetInfo::handleTargetFeatures(
310344
<< Feature << "-target-feature";
311345
return false;
312346
}
347+
348+
// The reference-types feature included the change to `call_indirect`
349+
// encodings to support overlong immediates.
350+
if (HasReferenceTypes) {
351+
HasCallIndirectOverlong = true;
352+
}
353+
354+
// bulk-memory-opt is a subset of bulk-memory.
355+
if (HasBulkMemory) {
356+
HasBulkMemoryOpt = true;
357+
}
358+
313359
return true;
314360
}
315361

‎clang/lib/Basic/Targets/WebAssembly.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public TargetInfo {
5555

5656
bool HasAtomics = false;
5757
bool HasBulkMemory = false;
58+
bool HasBulkMemoryOpt = false;
5859
bool HasExceptionHandling = false;
5960
bool HasExtendedConst = false;
6061
bool HasFP16 = false;
@@ -63,6 +64,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public TargetInfo {
6364
bool HasMutableGlobals = false;
6465
bool HasNontrappingFPToInt = false;
6566
bool HasReferenceTypes = false;
67+
bool HasCallIndirectOverlong = false;
6668
bool HasSignExt = false;
6769
bool HasTailCall = false;
6870
bool HasWideArithmetic = false;

‎lld/test/wasm/compress-relocs.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
; RUN: llc -filetype=obj %s -o %t.o
2-
; RUN: llvm-mc -mattr=+reference-types -filetype=obj -triple=wasm32-unknown-unknown %p/Inputs/call-indirect.s -o %t2.o
2+
; RUN: llvm-mc -mattr=+call-indirect-overlong -filetype=obj -triple=wasm32-unknown-unknown %p/Inputs/call-indirect.s -o %t2.o
33
; RUN: wasm-ld --export-dynamic -o %t.wasm %t2.o %t.o
44
; RUN: obj2yaml %t.wasm | FileCheck %s
55
; RUN: wasm-ld --export-dynamic -O2 -o %t-opt.wasm %t2.o %t.o

‎lld/test/wasm/import-table-explicit.s

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# RUN: llvm-mc -mattr=+reference-types -filetype=obj -triple=wasm32-unknown-unknown %s -o %t.o
1+
# RUN: llvm-mc -mattr=+call-indirect-overlong -filetype=obj -triple=wasm32-unknown-unknown %s -o %t.o
22
# RUN: wasm-ld --import-table -o %t.wasm %t.o
33
# RUN: obj2yaml %t.wasm | FileCheck %s
44

‎lld/test/wasm/invalid-mvp-table-use.s

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown -o %t.o %s
22
#
33
# If any table is defined or declared besides the __indirect_function_table,
4-
# the compilation unit should be compiled with -mattr=+reference-types,
4+
# the compilation unit should be compiled with -mattr=+call-indirect-overlong,
55
# causing symbol table entries to be emitted for all tables.
66
# RUN: not wasm-ld --no-entry %t.o -o %t.wasm 2>&1 | FileCheck -check-prefix=CHECK-ERR %s
77

‎lld/test/wasm/lto/Inputs/libcall-archive.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ define void @memcpy() #0 {
55
ret void
66
}
77

8-
attributes #0 = { "target-features"="-bulk-memory" }
8+
attributes #0 = { "target-features"="-bulk-memory,-bulk-memory-opt" }

‎lld/test/wasm/lto/libcall-archive.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ entry:
1616

1717
declare void @llvm.memcpy.p0.p0.i64(ptr nocapture, ptr nocapture, i64, i1)
1818

19-
attributes #0 = { "target-features"="-bulk-memory" }
19+
attributes #0 = { "target-features"="-bulk-memory,-bulk-memory-opt" }
2020

2121
; CHECK: - Type: CUSTOM
2222
; CHECK-NEXT: Name: name

‎lld/test/wasm/lto/stub-library-libcall.s

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown -o %t_main.o %t/main.s
33
# RUN: llvm-as %S/Inputs/foo.ll -o %t_foo.o
44
# RUN: llvm-as %S/Inputs/libcall.ll -o %t_libcall.o
5-
# RUN: wasm-ld -mllvm -mattr=-bulk-memory %t_main.o %t_libcall.o %t_foo.o %p/Inputs/stub.so -o %t.wasm
5+
# RUN: wasm-ld -mllvm -mattr=-bulk-memory,-bulk-memory-opt %t_main.o %t_libcall.o %t_foo.o %p/Inputs/stub.so -o %t.wasm
66
# RUN: obj2yaml %t.wasm | FileCheck %s
77

88
# The function `func_with_libcall` will generate an undefined reference to
@@ -12,7 +12,7 @@
1212
# If %t_foo.o is not included in the link we get an undefined symbol reported
1313
# to the dependency of memcpy on the foo export:
1414

15-
# RUN: not wasm-ld -mllvm -mattr=-bulk-memory %t_main.o %t_libcall.o %p/Inputs/stub.so -o %t.wasm 2>&1 | FileCheck --check-prefix=MISSING %s
15+
# RUN: not wasm-ld -mllvm -mattr=-bulk-memory,-bulk-memory-opt %t_main.o %t_libcall.o %p/Inputs/stub.so -o %t.wasm 2>&1 | FileCheck --check-prefix=MISSING %s
1616
# MISSING: stub.so: undefined symbol: foo. Required by memcpy
1717

1818
#--- main.s

‎lld/test/wasm/multi-table.s

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ call_indirect_explicit_tables:
2626
call_indirect table_b, () -> ()
2727
end_function
2828

29-
# RT-MVP: wasm-ld: error: object file not built with 'reference-types' feature conflicts with import of table table_a by file
29+
# RT-MVP: wasm-ld: error: object file not built with 'call-indirect-overlong' feature conflicts with import of table table_a by file
3030

3131
# CHECK: --- !WASM
3232
# CHECK-NEXT: FileHeader:

‎lld/wasm/InputFiles.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -255,10 +255,11 @@ static void setRelocs(const std::vector<T *> &chunks,
255255
}
256256
}
257257

258-
// An object file can have two approaches to tables. With the reference-types
259-
// feature enabled, input files that define or use tables declare the tables
260-
// using symbols, and record each use with a relocation. This way when the
261-
// linker combines inputs, it can collate the tables used by the inputs,
258+
// An object file can have two approaches to tables. With the
259+
// call-indirect-overlong feature enabled (explicitly, or implied by the
260+
// reference-types feature), input files that define or use tables declare the
261+
// tables using symbols, and record each use with a relocation. This way when
262+
// the linker combines inputs, it can collate the tables used by the inputs,
262263
// assigning them distinct table numbers, and renumber all the uses as
263264
// appropriate. At the same time, the linker has special logic to build the
264265
// indirect function table if it is needed.
@@ -284,7 +285,7 @@ void ObjFile::addLegacyIndirectFunctionTableIfNeeded(
284285
return;
285286

286287
// It's possible for an input to define tables and also use the indirect
287-
// function table, but forget to compile with -mattr=+reference-types.
288+
// function table, but forget to compile with -mattr=+call-indirect-overlong.
288289
// For these newer files, we require symbols for all tables, and
289290
// relocations for all of their uses.
290291
if (tableSymbolCount != 0) {

‎lld/wasm/SyntheticSections.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ void TableSection::addTable(InputTable *table) {
326326
// to assign table number 0 to the indirect function table.
327327
for (const auto *culprit : out.importSec->importedSymbols) {
328328
if (isa<UndefinedTable>(culprit)) {
329-
error("object file not built with 'reference-types' feature "
329+
error("object file not built with 'call-indirect-overlong' feature "
330330
"conflicts with import of table " +
331331
culprit->getName() + " by file " +
332332
toString(culprit->getFile()));

‎llvm/docs/ReleaseNotes.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,15 @@ and `-mbulk-memory` flags, which correspond to the [Bulk Memory Operations]
221221
and [Non-trapping float-to-int Conversions] language features, which are
222222
[widely implemented in engines].
223223

224+
A new Lime1 target CPU is added, -mcpu=lime1. This CPU follows the definition of
225+
the Lime1 CPU [here], and enables -mmultivalue, -mmutable-globals,
226+
-mcall-indirect-overlong, -msign-ext, -mbulk-memory-opt, -mnontrapping-fptoint,
227+
and -mextended-const.
228+
224229
[Bulk Memory Operations]: https://github.com/WebAssembly/bulk-memory-operations/blob/master/proposals/bulk-memory-operations/Overview.md
225230
[Non-trapping float-to-int Conversions]: https://github.com/WebAssembly/spec/blob/master/proposals/nontrapping-float-to-int-conversion/Overview.md
226231
[widely implemented in engines]: https://webassembly.org/features/
232+
[here]: https://github.com/WebAssembly/tool-conventions/blob/main/Lime.md#lime1
227233

228234
Changes to the Windows Target
229235
-----------------------------

‎llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,18 @@ class WebAssemblyAsmParser final : public MCTargetAsmParser {
276276
: MCTargetAsmParser(Options, STI, MII), Parser(Parser),
277277
Lexer(Parser.getLexer()), Is64(STI.getTargetTriple().isArch64Bit()),
278278
TC(Parser, MII, Is64), SkipTypeCheck(Options.MCNoTypeCheck) {
279-
setAvailableFeatures(ComputeAvailableFeatures(STI.getFeatureBits()));
279+
FeatureBitset FBS = ComputeAvailableFeatures(STI.getFeatureBits());
280+
281+
// bulk-memory implies bulk-memory-opt
282+
if (FBS.test(WebAssembly::FeatureBulkMemory)) {
283+
FBS.set(WebAssembly::FeatureBulkMemoryOpt);
284+
}
285+
// reference-types implies call-indirect-overlong
286+
if (FBS.test(WebAssembly::FeatureReferenceTypes)) {
287+
FBS.set(WebAssembly::FeatureCallIndirectOverlong);
288+
}
289+
290+
setAvailableFeatures(FBS);
280291
// Don't type check if this is inline asm, since that is a naked sequence of
281292
// instructions without a function/locals decl.
282293
auto &SM = Parser.getSourceManager();
@@ -291,7 +302,8 @@ class WebAssemblyAsmParser final : public MCTargetAsmParser {
291302

292303
DefaultFunctionTable = getOrCreateFunctionTableSymbol(
293304
getContext(), "__indirect_function_table", Is64);
294-
if (!STI->checkFeatures("+reference-types"))
305+
if (!STI->checkFeatures("+call-indirect-overlong") &&
306+
!STI->checkFeatures("+reference-types"))
295307
DefaultFunctionTable->setOmitFromLinkingSection();
296308
}
297309

@@ -531,11 +543,13 @@ class WebAssemblyAsmParser final : public MCTargetAsmParser {
531543
}
532544

533545
bool parseFunctionTableOperand(std::unique_ptr<WebAssemblyOperand> *Op) {
534-
if (STI->checkFeatures("+reference-types")) {
535-
// If the reference-types feature is enabled, there is an explicit table
536-
// operand. To allow the same assembly to be compiled with or without
537-
// reference types, we allow the operand to be omitted, in which case we
538-
// default to __indirect_function_table.
546+
if (STI->checkFeatures("+call-indirect-overlong") ||
547+
STI->checkFeatures("+reference-types")) {
548+
// If the call-indirect-overlong feature is enabled, or implied by the
549+
// reference-types feature, there is an explicit table operand. To allow
550+
// the same assembly to be compiled with or without
551+
// call-indirect-overlong, we allow the operand to be omitted, in which
552+
// case we default to __indirect_function_table.
539553
auto &Tok = Lexer.getTok();
540554
if (Tok.is(AsmToken::Identifier)) {
541555
auto *Sym =

‎llvm/lib/Target/WebAssembly/WebAssembly.td

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ def FeatureBulkMemory :
2929
SubtargetFeature<"bulk-memory", "HasBulkMemory", "true",
3030
"Enable bulk memory operations">;
3131

32+
def FeatureBulkMemoryOpt :
33+
SubtargetFeature<"bulk-memory-opt", "HasBulkMemoryOpt", "true",
34+
"Enable bulk memory optimization operations">;
35+
3236
def FeatureExceptionHandling :
3337
SubtargetFeature<"exception-handling", "HasExceptionHandling", "true",
3438
"Enable Wasm exception handling">;
@@ -63,6 +67,10 @@ def FeatureReferenceTypes :
6367
SubtargetFeature<"reference-types", "HasReferenceTypes", "true",
6468
"Enable reference types">;
6569

70+
def FeatureCallIndirectOverlong :
71+
SubtargetFeature<"call-indirect-overlong", "HasCallIndirectOverlong", "true",
72+
"Enable overlong encoding for call_indirect immediates">;
73+
6674
def FeatureRelaxedSIMD :
6775
SubtargetFeature<"relaxed-simd", "SIMDLevel", "RelaxedSIMD",
6876
"Enable relaxed-simd instructions">;
@@ -114,19 +122,27 @@ def : ProcessorModel<"mvp", NoSchedModel, []>;
114122
// consideration given to available support in relevant engines and tools, and
115123
// the importance of the features.
116124
def : ProcessorModel<"generic", NoSchedModel,
117-
[FeatureBulkMemory, FeatureMultivalue,
118-
FeatureMutableGlobals, FeatureNontrappingFPToInt,
119-
FeatureReferenceTypes, FeatureSignExt]>;
125+
[FeatureBulkMemory, FeatureBulkMemoryOpt,
126+
FeatureMultivalue, FeatureMutableGlobals,
127+
FeatureNontrappingFPToInt, FeatureReferenceTypes,
128+
FeatureCallIndirectOverlong, FeatureSignExt]>;
129+
130+
// Lime1: <https://github.com/WebAssembly/tool-conventions/blob/main/Lime.md#lime1>
131+
def : ProcessorModel<"lime1", NoSchedModel,
132+
[FeatureMultivalue, FeatureMutableGlobals,
133+
FeatureCallIndirectOverlong, FeatureSignExt,
134+
FeatureBulkMemoryOpt, FeatureNontrappingFPToInt,
135+
FeatureExtendedConst]>;
120136

121137
// Latest and greatest experimental version of WebAssembly. Bugs included!
122138
def : ProcessorModel<"bleeding-edge", NoSchedModel,
123-
[FeatureAtomics, FeatureBulkMemory,
139+
[FeatureAtomics, FeatureBulkMemory, FeatureBulkMemoryOpt,
124140
FeatureExceptionHandling, FeatureExtendedConst,
125141
FeatureFP16, FeatureMultiMemory,
126142
FeatureMultivalue, FeatureMutableGlobals,
127143
FeatureNontrappingFPToInt, FeatureRelaxedSIMD,
128-
FeatureReferenceTypes, FeatureSIMD128, FeatureSignExt,
129-
FeatureTailCall]>;
144+
FeatureReferenceTypes, FeatureCallIndirectOverlong,
145+
FeatureSIMD128, FeatureSignExt, FeatureTailCall]>;
130146

131147
//===----------------------------------------------------------------------===//
132148
// Target Declaration

‎llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -895,7 +895,7 @@ bool WebAssemblyFastISel::selectCall(const Instruction *I) {
895895
// The table into which this call_indirect indexes.
896896
MCSymbolWasm *Table = WebAssembly::getOrCreateFunctionTableSymbol(
897897
MF->getContext(), Subtarget);
898-
if (Subtarget->hasReferenceTypes()) {
898+
if (Subtarget->hasCallIndirectOverlong()) {
899899
MIB.addSym(Table);
900900
} else {
901901
// Otherwise for the MVP there is at most one table whose number is 0, but

‎llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ LowerCallResults(MachineInstr &CallResults, DebugLoc DL, MachineBasicBlock *BB,
768768
MF.getContext(), Subtarget)
769769
: WebAssembly::getOrCreateFunctionTableSymbol(
770770
MF.getContext(), Subtarget);
771-
if (Subtarget->hasReferenceTypes()) {
771+
if (Subtarget->hasCallIndirectOverlong()) {
772772
MIB.addSym(Table);
773773
} else {
774774
// For the MVP there is at most one table whose number is 0, but we can't

0 commit comments

Comments
 (0)