Skip to content

Commit 32dcdac

Browse files
Adjust based on review comments.
1 parent a77c6f9 commit 32dcdac

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

llvm/include/llvm/Analysis/LoopAccessAnalysis.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ class RuntimePointerChecking {
655655
/// For memory dependences that cannot be determined at compile time, it
656656
/// generates run-time checks to prove independence. This is done by
657657
/// AccessAnalysis::canCheckPtrAtRT and the checks are maintained by the
658-
/// RuntimePointerCheck class. AllowPartial determines whether partial checks
658+
/// RuntimePointerCheck class. \p AllowPartial determines whether partial checks
659659
/// are generated when not all pointers could be analyzed.
660660
///
661661
/// If pointers can wrap or can't be expressed as affine AddRec expressions by

llvm/lib/Analysis/LoopAccessAnalysis.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,8 @@ class AccessAnalysis {
697697
/// Returns true if we need no check or if we do and we can generate them
698698
/// (i.e. the pointers have computable bounds). A return value of false means
699699
/// we couldn't analyze and generate runtime checks for all pointers in the
700-
/// loop, but we will have checks for those pointers we could analyze.
700+
/// loop, but if \p AllowPartial is set then we will have checks for those
701+
/// pointers we could analyze.
701702
bool canCheckPtrAtRT(RuntimePointerChecking &RtCheck, Loop *TheLoop,
702703
const DenseMap<Value *, const SCEV *> &Strides,
703704
Value *&UncomputablePtr, bool AllowPartial);
@@ -1330,6 +1331,7 @@ bool AccessAnalysis::canCheckPtrAtRT(
13301331
// are needed. This can happen when all pointers point to the same underlying
13311332
// object for example.
13321333
RtCheck.Need = CanDoRT ? RtCheck.getNumberOfChecks() != 0 : MayNeedRTCheck;
1334+
13331335
bool CanDoRTIfNeeded = !RtCheck.Need || CanDoRT;
13341336
assert(CanDoRTIfNeeded == (CanDoRT || !MayNeedRTCheck) &&
13351337
"CanDoRTIfNeeded depends on RtCheck.Need");

0 commit comments

Comments
 (0)