Skip to content

Commit 33fca97

Browse files
committed
[CMake] Move LLDB_TEST_BUILD_DIRECTORY into test/CMakeLists.txt
The LLDB_TEST_BUILD_DIRECTORY variable only matters to the different test suites. Therefore they belong in test/CMakeLists.txt rather than the top-level CMakeLists.txt.
1 parent fd025c0 commit 33fca97

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lldb/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ add_subdirectory(docs)
8181

8282
option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests." ${LLVM_INCLUDE_TESTS})
8383
if(LLDB_INCLUDE_TESTS)
84-
set(LLDB_TEST_BUILD_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/lldb-test-build.noindex" CACHE PATH "The build root for building tests.")
85-
8684
add_subdirectory(test)
8785
add_subdirectory(unittests)
8886
add_subdirectory(utils/lit-cpuid)

lldb/test/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# Test runner infrastructure for LLDB. This configures the LLDB test trees
22
# for use by Lit, and delegates to LLVM's lit test handlers.
33

4+
# Configure the build directory.
5+
set(LLDB_TEST_BUILD_DIRECTORY "${PROJECT_BINARY_DIR}/lldb-test-build.noindex" CACHE PATH "The build root for building tests.")
6+
47
# Configure and create module cache directories.
58
set(LLDB_TEST_MODULE_CACHE_LLDB "${LLDB_TEST_BUILD_DIRECTORY}/module-cache-lldb" CACHE PATH "The Clang module cache used by the Clang embedded in LLDB while running tests.")
69
set(LLDB_TEST_MODULE_CACHE_CLANG "${LLDB_TEST_BUILD_DIRECTORY}/module-cache-clang" CACHE PATH "The Clang module cache used by the Clang while building tests.")

0 commit comments

Comments
 (0)