Apply clang-tidy fixes for llvm-prefer-isa-or-dyn-cast-in-conditionals in MapMemRefStorageClassPass.cpp (NFC)

joker-eph · joker-eph · commit 345d574b6587 · 2023-12-07T21:39:25.000-08:00
diff --git a/mlir/lib/Conversion/MemRefToSPIRV/MapMemRefStorageClassPass.cpp b/mlir/lib/Conversion/MemRefToSPIRV/MapMemRefStorageClassPass.cpp
@@ -205,7 +205,7 @@ spirv::MemorySpaceToStorageClassConverter::MemorySpaceToStorageClassConverter(
 static bool isLegalType(Type type) {
   if (auto memRefType = dyn_cast<BaseMemRefType>(type)) {
     Attribute spaceAttr = memRefType.getMemorySpace();
-    return spaceAttr && isa<spirv::StorageClassAttr>(spaceAttr);
+    return isa_and_nonnull<spirv::StorageClassAttr>(spaceAttr);
   }
   return true;
 }

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ spirv::MemorySpaceToStorageClassConverter::MemorySpaceToStorageClassConverter(`
`205`	`205`	`static bool isLegalType(Type type) {`
`206`	`206`	`if (auto memRefType = dyn_cast<BaseMemRefType>(type)) {`
`207`	`207`	`Attribute spaceAttr = memRefType.getMemorySpace();`
`208`		`- return spaceAttr && isa<spirv::StorageClassAttr>(spaceAttr);`
	`208`	`+ return isa_and_nonnull<spirv::StorageClassAttr>(spaceAttr);`
`209`	`209`	`}`
`210`	`210`	`return true;`
`211`	`211`	`}`