Skip to content

Commit 34e7809

Browse files
arsenmarsenm
authored
unittests: Avoid using getNumUses (#136352)
1 parent 3ad353c commit 34e7809

File tree

5 files changed

+34
-34
lines changed

5 files changed

+34
-34
lines changed

‎llvm/unittests/Analysis/CGSCCPassManagerTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1641,7 +1641,7 @@ TEST_F(CGSCCPassManagerTest, TestUpdateCGAndAnalysisManagerForPasses8) {
16411641
CGU.initialize(CG, C, AM, UR);
16421642
ASSERT_NO_FATAL_FAILURE(CGU.replaceFunctionWith(*FnF, *FnewF));
16431643
ASSERT_TRUE(FnF->isDeclaration());
1644-
ASSERT_EQ(FnF->getNumUses(), 0U);
1644+
ASSERT_TRUE(FnF->use_empty());
16451645
}));
16461646

16471647
ModulePassManager MPM;

‎llvm/unittests/Analysis/LazyCallGraphTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1155,7 +1155,7 @@ TEST(LazyCallGraphTest, InlineAndDeleteFunction) {
11551155
ASSERT_EQ(&D2F, D1Call->getCalledFunction());
11561156
C1Call->setCalledFunction(&D3.getFunction());
11571157
D1Call->setCalledFunction(&D3.getFunction());
1158-
ASSERT_EQ(0u, D2F.getNumUses());
1158+
ASSERT_TRUE(D2F.use_empty());
11591159

11601160
// Insert new edges first.
11611161
CRC.insertTrivialCallEdge(C1, D3);

‎llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ static Value *findStoredValueInAggregateAt(LLVMContext &Ctx, Value *Aggregate,
325325
}
326326

327327
EXPECT_NE(GEPAtIdx, nullptr);
328-
EXPECT_EQ(GEPAtIdx->getNumUses(), 1U);
328+
EXPECT_TRUE(GEPAtIdx->hasOneUse());
329329

330330
// Find the value stored to the aggregate.
331331
StoreInst *StoreToAgg = dyn_cast<StoreInst>(*GEPAtIdx->user_begin());
@@ -443,7 +443,7 @@ TEST_F(OpenMPIRBuilderTest, CreateCancel) {
443443
EXPECT_EQ(Cancel->getCalledFunction()->getName(), "__kmpc_cancel");
444444
EXPECT_FALSE(Cancel->getCalledFunction()->doesNotAccessMemory());
445445
EXPECT_FALSE(Cancel->getCalledFunction()->doesNotFreeMemory());
446-
EXPECT_EQ(Cancel->getNumUses(), 1U);
446+
EXPECT_TRUE(Cancel->hasOneUse());
447447
Instruction *CancelBBTI = Cancel->getParent()->getTerminator();
448448
EXPECT_EQ(CancelBBTI->getNumSuccessors(), 2U);
449449
EXPECT_EQ(CancelBBTI->getSuccessor(0), NewIP.getBlock());
@@ -460,7 +460,7 @@ TEST_F(OpenMPIRBuilderTest, CreateCancel) {
460460
EXPECT_EQ(Barrier->getCalledFunction()->getName(), "__kmpc_cancel_barrier");
461461
EXPECT_FALSE(Barrier->getCalledFunction()->doesNotAccessMemory());
462462
EXPECT_FALSE(Barrier->getCalledFunction()->doesNotFreeMemory());
463-
EXPECT_EQ(Barrier->getNumUses(), 0U);
463+
EXPECT_TRUE(Barrier->use_empty());
464464
EXPECT_EQ(CancelBBTI->getSuccessor(1)->getTerminator()->getNumSuccessors(),
465465
1U);
466466
EXPECT_EQ(CancelBBTI->getSuccessor(1)->getTerminator()->getSuccessor(0), CBB);
@@ -516,7 +516,7 @@ TEST_F(OpenMPIRBuilderTest, CreateCancelIfCond) {
516516
EXPECT_EQ(Cancel->getCalledFunction()->getName(), "__kmpc_cancel");
517517
EXPECT_FALSE(Cancel->getCalledFunction()->doesNotAccessMemory());
518518
EXPECT_FALSE(Cancel->getCalledFunction()->doesNotFreeMemory());
519-
EXPECT_EQ(Cancel->getNumUses(), 1U);
519+
EXPECT_TRUE(Cancel->hasOneUse());
520520
Instruction *CancelBBTI = Cancel->getParent()->getTerminator();
521521
EXPECT_EQ(CancelBBTI->getNumSuccessors(), 2U);
522522
EXPECT_EQ(CancelBBTI->getSuccessor(0)->size(), 1U);
@@ -535,7 +535,7 @@ TEST_F(OpenMPIRBuilderTest, CreateCancelIfCond) {
535535
EXPECT_EQ(Barrier->getCalledFunction()->getName(), "__kmpc_cancel_barrier");
536536
EXPECT_FALSE(Barrier->getCalledFunction()->doesNotAccessMemory());
537537
EXPECT_FALSE(Barrier->getCalledFunction()->doesNotFreeMemory());
538-
EXPECT_EQ(Barrier->getNumUses(), 0U);
538+
EXPECT_TRUE(Barrier->use_empty());
539539
EXPECT_EQ(CancelBBTI->getSuccessor(1)->getTerminator()->getNumSuccessors(),
540540
1U);
541541
EXPECT_EQ(CancelBBTI->getSuccessor(1)->getTerminator()->getSuccessor(0), CBB);
@@ -586,7 +586,7 @@ TEST_F(OpenMPIRBuilderTest, CreateCancelBarrier) {
586586
EXPECT_EQ(Barrier->getCalledFunction()->getName(), "__kmpc_cancel_barrier");
587587
EXPECT_FALSE(Barrier->getCalledFunction()->doesNotAccessMemory());
588588
EXPECT_FALSE(Barrier->getCalledFunction()->doesNotFreeMemory());
589-
EXPECT_EQ(Barrier->getNumUses(), 1U);
589+
EXPECT_TRUE(Barrier->hasOneUse());
590590
Instruction *BarrierBBTI = Barrier->getParent()->getTerminator();
591591
EXPECT_EQ(BarrierBBTI->getNumSuccessors(), 2U);
592592
EXPECT_EQ(BarrierBBTI->getSuccessor(0), NewIP.getBlock());
@@ -741,7 +741,7 @@ TEST_F(OpenMPIRBuilderTest, ParallelSimpleGPU) {
741741
EXPECT_EQ(OutlinedFn->getArg(2)->getType(),
742742
PointerType::get(M->getContext(), 0));
743743
EXPECT_EQ(&OutlinedFn->getEntryBlock(), PrivAI->getParent());
744-
EXPECT_EQ(OutlinedFn->getNumUses(), 1U);
744+
EXPECT_TRUE(OutlinedFn->hasOneUse());
745745
User *Usr = OutlinedFn->user_back();
746746
ASSERT_TRUE(isa<CallInst>(Usr));
747747
CallInst *Parallel51CI = dyn_cast<CallInst>(Usr);
@@ -849,7 +849,7 @@ TEST_F(OpenMPIRBuilderTest, ParallelSimple) {
849849
EXPECT_EQ(OutlinedFn->arg_size(), 3U);
850850

851851
EXPECT_EQ(&OutlinedFn->getEntryBlock(), PrivAI->getParent());
852-
EXPECT_EQ(OutlinedFn->getNumUses(), 1U);
852+
EXPECT_TRUE(OutlinedFn->hasOneUse());
853853
User *Usr = OutlinedFn->user_back();
854854
ASSERT_TRUE(isa<CallInst>(Usr));
855855
CallInst *ForkCI = dyn_cast<CallInst>(Usr);
@@ -952,7 +952,7 @@ TEST_F(OpenMPIRBuilderTest, ParallelNested) {
952952
EXPECT_TRUE(OutlinedFn.hasInternalLinkage());
953953
EXPECT_EQ(OutlinedFn.arg_size(), 2U);
954954

955-
EXPECT_EQ(OutlinedFn.getNumUses(), 1U);
955+
EXPECT_TRUE(OutlinedFn.hasOneUse());
956956
User *Usr = OutlinedFn.user_back();
957957
ASSERT_TRUE(isa<CallInst>(Usr));
958958
CallInst *ForkCI = dyn_cast<CallInst>(Usr);
@@ -1071,7 +1071,7 @@ TEST_F(OpenMPIRBuilderTest, ParallelNested2Inner) {
10711071
NumAllocas += isa<AllocaInst>(I);
10721072
EXPECT_EQ(NumAllocas, 1U);
10731073

1074-
EXPECT_EQ(OutlinedFn.getNumUses(), 1U);
1074+
EXPECT_TRUE(OutlinedFn.hasOneUse());
10751075
User *Usr = OutlinedFn.user_back();
10761076
ASSERT_TRUE(isa<CallInst>(Usr));
10771077
CallInst *ForkCI = dyn_cast<CallInst>(Usr);
@@ -1178,7 +1178,7 @@ TEST_F(OpenMPIRBuilderTest, ParallelIfCond) {
11781178
EXPECT_EQ(OutlinedFn->arg_size(), 3U);
11791179

11801180
EXPECT_EQ(&OutlinedFn->getEntryBlock(), PrivAI->getParent());
1181-
ASSERT_EQ(OutlinedFn->getNumUses(), 1U);
1181+
ASSERT_TRUE(OutlinedFn->hasOneUse());
11821182

11831183
CallInst *ForkCI = nullptr;
11841184
for (User *Usr : OutlinedFn->users()) {
@@ -1229,9 +1229,9 @@ TEST_F(OpenMPIRBuilderTest, ParallelCancelBarrier) {
12291229
BFn = M->getFunction("__kmpc_barrier");
12301230
ASSERT_NE(CBFn, nullptr);
12311231
ASSERT_EQ(BFn, nullptr);
1232-
ASSERT_EQ(CBFn->getNumUses(), 1U);
1232+
ASSERT_TRUE(CBFn->hasOneUse());
12331233
ASSERT_TRUE(isa<CallInst>(CBFn->user_back()));
1234-
ASSERT_EQ(CBFn->user_back()->getNumUses(), 1U);
1234+
ASSERT_TRUE(CBFn->user_back()->hasOneUse());
12351235
CheckedBarrier = cast<CallInst>(CBFn->user_back());
12361236

12371237
ASSERT_EXPECTED_INIT(
@@ -1242,20 +1242,20 @@ TEST_F(OpenMPIRBuilderTest, ParallelCancelBarrier) {
12421242
BFn = M->getFunction("__kmpc_barrier");
12431243
ASSERT_NE(CBFn, nullptr);
12441244
ASSERT_NE(BFn, nullptr);
1245-
ASSERT_EQ(CBFn->getNumUses(), 1U);
1246-
ASSERT_EQ(BFn->getNumUses(), 1U);
1245+
ASSERT_TRUE(CBFn->hasOneUse());
1246+
ASSERT_TRUE(BFn->hasOneUse());
12471247
ASSERT_TRUE(isa<CallInst>(BFn->user_back()));
1248-
ASSERT_EQ(BFn->user_back()->getNumUses(), 0U);
1248+
ASSERT_TRUE(BFn->user_back()->use_empty());
12491249

12501250
ASSERT_EXPECTED_INIT(OpenMPIRBuilder::InsertPointTy, BarrierIP3,
12511251
OMPBuilder.createBarrier(Builder.saveIP(),
12521252
OMPD_parallel, false, false));
12531253
Builder.restoreIP(BarrierIP3);
1254-
ASSERT_EQ(CBFn->getNumUses(), 2U);
1255-
ASSERT_EQ(BFn->getNumUses(), 1U);
1254+
ASSERT_TRUE(CBFn->hasNUses(2));
1255+
ASSERT_TRUE(BFn->hasOneUse());
12561256
ASSERT_TRUE(CBFn->user_back() != CheckedBarrier);
12571257
ASSERT_TRUE(isa<CallInst>(CBFn->user_back()));
1258-
ASSERT_EQ(CBFn->user_back()->getNumUses(), 0U);
1258+
ASSERT_TRUE(CBFn->user_back()->use_empty());
12591259
};
12601260

12611261
auto PrivCB = [&](InsertPointTy, InsertPointTy, Value &V, Value &,
@@ -1289,7 +1289,7 @@ TEST_F(OpenMPIRBuilderTest, ParallelCancelBarrier) {
12891289
EXPECT_EQ(NumBodiesGenerated, 1U);
12901290
EXPECT_EQ(NumPrivatizedVars, 0U);
12911291
EXPECT_EQ(NumFinalizationPoints, 2U);
1292-
EXPECT_EQ(FakeDestructor->getNumUses(), 2U);
1292+
EXPECT_TRUE(FakeDestructor->hasNUses(2));
12931293

12941294
Builder.restoreIP(AfterIP);
12951295
Builder.CreateRetVoid();
@@ -3988,7 +3988,7 @@ TEST_F(OpenMPIRBuilderTest, OMPAtomicUpdate) {
39883988
EXPECT_EQ(Phi->getIncomingBlock(0), EntryBB);
39893989
EXPECT_EQ(Phi->getIncomingBlock(1), ContBB);
39903990

3991-
EXPECT_EQ(Sub->getNumUses(), 1U);
3991+
EXPECT_TRUE(Sub->hasOneUse());
39923992
StoreInst *St = dyn_cast<StoreInst>(Sub->user_back());
39933993
AllocaInst *UpdateTemp = dyn_cast<AllocaInst>(St->getPointerOperand());
39943994

@@ -4058,7 +4058,7 @@ TEST_F(OpenMPIRBuilderTest, OMPAtomicUpdateFloat) {
40584058
EXPECT_EQ(Phi->getIncomingBlock(0), EntryBB);
40594059
EXPECT_EQ(Phi->getIncomingBlock(1), ContBB);
40604060

4061-
EXPECT_EQ(Sub->getNumUses(), 1U);
4061+
EXPECT_TRUE(Sub->hasOneUse());
40624062
StoreInst *St = dyn_cast<StoreInst>(Sub->user_back());
40634063
AllocaInst *UpdateTemp = dyn_cast<AllocaInst>(St->getPointerOperand());
40644064

@@ -4127,7 +4127,7 @@ TEST_F(OpenMPIRBuilderTest, OMPAtomicUpdateIntr) {
41274127
EXPECT_EQ(Phi->getIncomingBlock(0), EntryBB);
41284128
EXPECT_EQ(Phi->getIncomingBlock(1), ContBB);
41294129

4130-
EXPECT_EQ(Sub->getNumUses(), 1U);
4130+
EXPECT_TRUE(Sub->hasOneUse());
41314131
StoreInst *St = dyn_cast<StoreInst>(Sub->user_back());
41324132
AllocaInst *UpdateTemp = dyn_cast<AllocaInst>(St->getPointerOperand());
41334133

@@ -4942,7 +4942,7 @@ TEST_F(OpenMPIRBuilderTest, CreateTeamsWithIfConditionAndNumTeams) {
49424942
Value *ThreadLimitArg = PushNumTeamsCallInst->getArgOperand(4);
49434943

49444944
// Get the boolean conversion of if expression
4945-
ASSERT_EQ(IfExpr->getNumUses(), 1U);
4945+
ASSERT_TRUE(IfExpr->hasOneUse());
49464946
User *IfExprInst = IfExpr->user_back();
49474947
ICmpInst *IfExprCmpInst = dyn_cast<ICmpInst>(IfExprInst);
49484948
ASSERT_NE(IfExprCmpInst, nullptr);
@@ -5272,7 +5272,7 @@ TEST_F(OpenMPIRBuilderTest, CreateReductions) {
52725272
// Find the GEP instructions preceding stores to the local array.
52735273
Value *FirstArrayElemPtr = nullptr;
52745274
Value *SecondArrayElemPtr = nullptr;
5275-
EXPECT_EQ(LocalArray->getNumUses(), 3u);
5275+
EXPECT_TRUE(LocalArray->hasNUses(3));
52765276
ASSERT_TRUE(
52775277
findGEPZeroOne(LocalArray, FirstArrayElemPtr, SecondArrayElemPtr));
52785278

@@ -5292,7 +5292,7 @@ TEST_F(OpenMPIRBuilderTest, CreateReductions) {
52925292

52935293
// Check that the result of the runtime reduction call is used for further
52945294
// dispatch.
5295-
ASSERT_EQ(SwitchArg->getNumUses(), 1u);
5295+
ASSERT_TRUE(SwitchArg->hasOneUse());
52965296
SwitchInst *Switch = dyn_cast<SwitchInst>(*SwitchArg->user_begin());
52975297
ASSERT_NE(Switch, nullptr);
52985298
EXPECT_EQ(Switch->getNumSuccessors(), 3u);
@@ -6296,7 +6296,7 @@ TEST_F(OpenMPIRBuilderTest, TargetRegion) {
62966296
// Check num_teams and num_threads kernel arguments (use number 5 starting
62976297
// from the end and counting the call to __tgt_target_kernel as the first use)
62986298
Value *KernelArgs = Call->getArgOperand(Call->arg_size() - 1);
6299-
EXPECT_TRUE(KernelArgs->getNumUses() >= 4);
6299+
EXPECT_TRUE(KernelArgs->hasNUsesOrMore(4));
63006300
Value *NumTeamsGetElemPtr = *std::next(KernelArgs->user_begin(), 3);
63016301
EXPECT_TRUE(isa<GetElementPtrInst>(NumTeamsGetElemPtr));
63026302
Value *NumTeamsStore = NumTeamsGetElemPtr->getUniqueUndroppableUser();
@@ -6622,7 +6622,7 @@ TEST_F(OpenMPIRBuilderTest, TargetRegionSPMD) {
66226622
// Check the trip count kernel argument (use number 5 starting from the end
66236623
// and counting the call to __tgt_target_kernel as the first use)
66246624
Value *KernelArgs = Call->getArgOperand(Call->arg_size() - 1);
6625-
EXPECT_TRUE(KernelArgs->getNumUses() >= 6);
6625+
EXPECT_TRUE(KernelArgs->hasNUsesOrMore(6));
66266626
Value *TripCountGetElemPtr = *std::next(KernelArgs->user_begin(), 5);
66276627
EXPECT_TRUE(isa<GetElementPtrInst>(TripCountGetElemPtr));
66286628
Value *TripCountStore = TripCountGetElemPtr->getUniqueUndroppableUser();
@@ -7024,7 +7024,7 @@ TEST_F(OpenMPIRBuilderTest, CreateTask) {
70247024
// Verify that the data argument is used only once, and that too in the load
70257025
// instruction that is then used for accessing shared data.
70267026
Value *DataPtr = OutlinedFn->getArg(1);
7027-
EXPECT_EQ(DataPtr->getNumUses(), 1U);
7027+
EXPECT_TRUE(DataPtr->hasOneUse());
70287028
EXPECT_TRUE(isa<LoadInst>(DataPtr->uses().begin()->getUser()));
70297029
Value *Data = DataPtr->uses().begin()->getUser();
70307030
EXPECT_TRUE(all_of(Data->uses(), [](Use &U) {
@@ -7501,7 +7501,7 @@ TEST_F(OpenMPIRBuilderTest, CreateTaskgroupWithTasks) {
75017501

75027502
Function *TaskAllocFn =
75037503
OMPBuilder.getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_omp_task_alloc);
7504-
ASSERT_EQ(TaskAllocFn->getNumUses(), 2u);
7504+
ASSERT_TRUE(TaskAllocFn->hasNUses(2));
75057505

75067506
CallInst *FirstTaskAllocCall =
75077507
dyn_cast_or_null<CallInst>(*TaskAllocFn->users().begin());

‎llvm/unittests/IR/ValueHandleTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ TEST_F(ValueHandle, CallbackVH_DeletionCanRAUW) {
329329
}
330330
void allUsesReplacedWith(Value *new_value) override {
331331
ASSERT_TRUE(nullptr != getValPtr());
332-
EXPECT_EQ(1U, getValPtr()->getNumUses());
332+
EXPECT_TRUE(getValPtr()->hasOneUse());
333333
EXPECT_EQ(nullptr, AURWArgument);
334334
AURWArgument = new_value;
335335
}

‎llvm/unittests/Linker/LinkModulesTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ TEST_F(LinkModuleTest, RemangleIntrinsics) {
358358
// types, so they must be uniquified by linker. Check that they use the same
359359
// intrinsic definition.
360360
Function *F = Foo->getFunction("llvm.ssa.copy.s_struct.rtx_defs");
361-
ASSERT_EQ(F->getNumUses(), (unsigned)2);
361+
ASSERT_TRUE(F->hasNUses(2));
362362
}
363363

364364
} // end anonymous namespace

0 commit comments

Comments
 (0)