Skip to content

Commit 35d7fff

Browse files
committed
Remove the unnecessary -mllvm flag.
1 parent 788271b commit 35d7fff

File tree

5 files changed

+11
-18
lines changed

5 files changed

+11
-18
lines changed

llvm/lib/CodeGen/TargetPassConfig.cpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -255,12 +255,6 @@ static cl::opt<bool>
255255
GCEmptyBlocks("gc-empty-basic-blocks", cl::init(false), cl::Hidden,
256256
cl::desc("Enable garbage-collecting empty basic blocks"));
257257

258-
/// Enable basic block path cloning with basic-block-sections.
259-
static cl::opt<bool> EnableBasicBlockPathCloning(
260-
"enable-basic-block-path-cloning", cl::Hidden,
261-
cl::desc("Applies basic cloning clonings specified in the basic block "
262-
"sections profile."));
263-
264258
/// Allow standard passes to be disabled by command line options. This supports
265259
/// simple binary flags that either suppress the pass or do nothing.
266260
/// i.e. -disable-mypass=false has no effect.
@@ -1273,8 +1267,7 @@ void TargetPassConfig::addMachinePasses() {
12731267
if (TM->getBBSectionsType() == llvm::BasicBlockSection::List) {
12741268
addPass(llvm::createBasicBlockSectionsProfileReaderPass(
12751269
TM->getBBSectionsFuncListBuf()));
1276-
if (EnableBasicBlockPathCloning)
1277-
addPass(llvm::createBasicBlockPathCloningPass());
1270+
addPass(llvm::createBasicBlockPathCloningPass());
12781271
}
12791272
addPass(llvm::createBasicBlockSectionsPass());
12801273
} else if (TM->Options.EnableMachineFunctionSplitter ||

llvm/test/CodeGen/X86/basic-block-sections-cloning-indirect-invalid.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ declare void @effect(i32 zeroext)
77
; RUN: echo 'f bar' >> %t1
88
; RUN: echo 'p 0 1 2' >> %t1
99
; RUN: echo 'c 0 1.1 2.1 1' >> %t1
10-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t1 2> %t1.err | FileCheck %s
10+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t1 2> %t1.err | FileCheck %s
1111
; RUN: FileCheck %s --check-prefix=WARN < %t1.err
1212
; RUN: echo 'v1' > %t2
1313
; RUN: echo 'f bar' >> %t2
1414
; RUN: echo 'p 1 2' >> %t2
1515
; RUN: echo 'c 0 1 2.1' >> %t2
16-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t2 2> %t2.err | FileCheck %s
16+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t2 2> %t2.err | FileCheck %s
1717
; RUN: FileCheck %s --check-prefix=WARN < %t2.err
1818

1919

llvm/test/CodeGen/X86/basic-block-sections-cloning-indirect.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ declare void @effect(i32 zeroext)
77
; RUN: echo 'f bar' >> %t
88
; RUN: echo 'p 0 1' >> %t
99
; RUN: echo 'c 0 1.1 2 1' >> %t
10-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t | FileCheck %s
10+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t | FileCheck %s
1111

1212
define void @bar(i1 %a, i1 %b) {
1313
b0:

llvm/test/CodeGen/X86/basic-block-sections-cloning-invalid.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,21 @@ declare void @effect(i32 zeroext)
77
; RUN: echo 'f foo' >> %t1
88
; RUN: echo 'p 0 2 3' >> %t1
99
; RUN: echo 'c 0 2.1 3.1 1' >> %t1
10-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t1 2> %t1.err | FileCheck %s
10+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t1 2> %t1.err | FileCheck %s
1111
; RUN: FileCheck %s --check-prefixes=WARN1 < %t1.err
1212
;; Test that valid clonings are applied correctly, even if invalid clonings exist.
1313
; RUN: echo 'v1' > %t2
1414
; RUN: echo 'f foo' >> %t2
1515
; RUN: echo 'p 0 2 3' >> %t2
1616
; RUN: echo 'p 0 1 3' >> %t2
1717
; RUN: echo 'c 0 1.1 3.2 2.1 3.1 1' >> %t2
18-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t2 2> %t2.err | FileCheck %s --check-prefixes=PATH2
18+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t2 2> %t2.err | FileCheck %s --check-prefixes=PATH2
1919
; RUN: FileCheck %s --check-prefixes=WARN1 < %t2.err
2020
; RUN: echo 'v1' > %t3
2121
; RUN: echo 'f foo' >> %t3
2222
; RUN: echo 'p 0 100' >> %t3
2323
; RUN: echo 'c 0 100.1 1' >> %t3
24-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t3 2> %t3.err | FileCheck %s
24+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t3 2> %t3.err | FileCheck %s
2525
; RUN: FileCheck %s --check-prefixes=WARN2 < %t3.err
2626

2727
define void @foo(i1 %a, i1 %b, i1 %c, i1 %d) {

llvm/test/CodeGen/X86/basic-block-sections-cloning.ll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@ declare void @effect(i32 zeroext)
77
; RUN: echo 'f foo' >> %t1
88
; RUN: echo 'p 0 3 5' >> %t1
99
; RUN: echo 'c 0 3.1 5.1 1 2 3 4 5' >> %t1
10-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t1 | FileCheck %s --check-prefixes=PATH1
11-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t1 -stop-after=bb-path-cloning | FileCheck %s --check-prefix=PATH1MIR
10+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t1 | FileCheck %s --check-prefixes=PATH1
11+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t1 -stop-after=bb-path-cloning | FileCheck %s --check-prefix=PATH1MIR
1212
; RUN: echo 'v1' > %t2
1313
; RUN: echo 'f foo' >> %t2
1414
; RUN: echo 'p 0 3 5' >> %t2
1515
; RUN: echo 'p 1 3 4 5' >> %t2
1616
; RUN: echo 'c 0 3.1 5.1' >> %t2
1717
; RUN: echo 'c 1 3.2 4.1 5.2 2 3 4 5' >> %t2
18-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t2 | FileCheck %s --check-prefixes=PATH2
19-
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -enable-basic-block-path-cloning -basic-block-sections=%t2 -stop-after=bb-path-cloning | FileCheck %s --check-prefix=PATH2MIR
18+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t2 | FileCheck %s --check-prefixes=PATH2
19+
; RUN: llc < %s -mtriple=x86_64-pc-linux -O0 -function-sections -basic-block-sections=%t2 -stop-after=bb-path-cloning | FileCheck %s --check-prefix=PATH2MIR
2020

2121
define void @foo(i1 %a, i1 %b, i1 %c, i1 %d) {
2222
b0:

0 commit comments

Comments
 (0)