Skip to content

Commit 36c8a9a

Browse files
author
Peiming Liu
committed
[mlir][sparse] rephrase the documentation for sparse compiler create-sparse-deallocs option.
To address post-submit comments in https://reviews.llvm.org/D147010. Reviewed By: wrengr Differential Revision: https://reviews.llvm.org/D147014
1 parent 4d683f7 commit 36c8a9a

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

mlir/include/mlir/Dialect/SparseTensor/Pipelines/Passes.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,11 @@ struct SparseCompilerOptions
7575

7676
PassOptions::Option<bool> createSparseDeallocs{
7777
*this, "create-sparse-deallocs",
78-
desc("Specify if the temporary sparse buffer created by the sparse "
78+
desc("Specify if the temporary buffers created by the sparse "
7979
"compiler should be deallocated. For compatibility with core "
8080
"bufferization passes. "
81-
"It only takes effect when enable-runtime-library=false, otherwise "
82-
"the memory storage for sparse tensors are managed by the runtime "
83-
"library. See also create-deallocs for BufferizationOption."),
81+
"This option is only used when enable-runtime-library=false. "
82+
"See also create-deallocs for BufferizationOption."),
8483
init(true)};
8584

8685
PassOptions::Option<int32_t> vectorLength{

mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,12 +221,11 @@ def SparseTensorCodegen : Pass<"sparse-tensor-codegen", "ModuleOp"> {
221221
Option<"enableBufferInitialization", "enable-buffer-initialization", "bool",
222222
"false", "Enable zero-initialization of the memory buffers">,
223223
Option<"createSparseDeallocs", "create-sparse-deallocs", "bool",
224-
"true", "Specify if the temporary sparse buffer created by the sparse "
224+
"true", "Specify if the temporary buffers created by the sparse "
225225
"compiler should be deallocated. For compatibility with core "
226226
"bufferization passes. "
227-
"It only takes effect when enable-runtime-library=false, otherwise "
228-
"the memory storage for sparse tensors are managed by the runtime "
229-
"library. See also create-deallocs for BufferizationOption.">,
227+
"This option is only used when enable-runtime-library=false. "
228+
"See also create-deallocs for BufferizationOption.">,
230229
];
231230
}
232231

0 commit comments

Comments
 (0)