Skip to content

Commit 386a45c

Browse files
[mlir] Fix warnings
This patch fixes: include/c++/14/bits/unique_ptr.h:93:2: error: delete called on non-final '(anonymous namespace)::MPICHImplTraits' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor]
1 parent 7c1f679 commit 386a45c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ class MPIImplTraits {
6262

6363
explicit MPIImplTraits(ModuleOp &moduleOp) : moduleOp(moduleOp) {}
6464

65+
virtual ~MPIImplTraits() = default;
66+
6567
ModuleOp &getModuleOp() { return moduleOp; }
6668

6769
/// Gets or creates MPI_COMM_WORLD as a Value.
@@ -96,6 +98,8 @@ class MPICHImplTraits : public MPIImplTraits {
9698
public:
9799
using MPIImplTraits::MPIImplTraits;
98100

101+
virtual ~MPICHImplTraits() = default;
102+
99103
Value getCommWorld(const Location loc,
100104
ConversionPatternRewriter &rewriter) override {
101105
static constexpr int MPI_COMM_WORLD = 0x44000000;
@@ -152,6 +156,8 @@ class OMPIImplTraits : public MPIImplTraits {
152156
public:
153157
using MPIImplTraits::MPIImplTraits;
154158

159+
virtual ~OMPIImplTraits() = default;
160+
155161
Value getCommWorld(const Location loc,
156162
ConversionPatternRewriter &rewriter) override {
157163
auto context = rewriter.getContext();

0 commit comments

Comments
 (0)