Skip to content

Commit 391a5ae

Browse files
committed
Fix tests
1 parent 8c42dd3 commit 391a5ae

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ bool DynamicLoaderPOSIXDYLD::SetRendezvousBreakpoint() {
298298
"Rendezvous breakpoint breakpoint id {0} for pid {1}"
299299
"is already set.",
300300
m_dyld_bid,
301-
m_process ? m_process->GetID() : LLDB_INVALID_PROCESS_ID);
302301
return true;
303302
}
304303

lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,14 @@ def minidump_saves_fs_base_region(self):
567567
os.unlink(custom_file)
568568

569569
def minidump_deterministic_difference(self):
570-
"""Test that verifies that two minidumps produced are identical."""
570+
"""Test that verifies that two minidumps produced are identical."""
571+
self.build()
572+
exe = self.getBuildArtifact("a.out")
573+
try:
574+
target = self.dbg.CreateTarget(exe)
575+
process = target.LaunchSimple(
576+
None, None, self.get_process_working_directory()
577+
)
571578

572579
core_styles = [
573580
lldb.eSaveCoreStackOnly,
@@ -596,7 +603,6 @@ def minidump_deterministic_difference(self):
596603
self.assertEqual(file_one, file_two)
597604
self.assertTrue(os.unlink(spec_one.GetFileName()))
598605
self.assertTrue(os.unlink(spec_two.GetFileName()))
599-
600606
finally:
601607
self.assertTrue(self.dbg.DeleteTarget(target))
602608

0 commit comments

Comments
 (0)