Skip to content

Commit 3af4c2e

Browse files
authored
[libc++][test] Clean up code in GenerateInput.h for benchmark testing (#115560)
This PR refines the code in `GenerateInput.h` used for benchmark testing by implementing the following changes: - Replaced all unqualified usages of `size_t` with `std::size_t`. - Removed unnecessary curly braces `{}` from for loops that contain simple single-statement bodies, in accordance with LLVM coding standards.
1 parent 30feb35 commit 3af4c2e

File tree

1 file changed

+20
-24
lines changed

1 file changed

+20
-24
lines changed

libcxx/test/benchmarks/GenerateInput.h

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -45,38 +45,37 @@ inline std::string getRandomString(std::size_t Len) {
4545
}
4646

4747
template <class IntT>
48-
inline std::vector<IntT> getDuplicateIntegerInputs(size_t N) {
48+
inline std::vector<IntT> getDuplicateIntegerInputs(std::size_t N) {
4949
std::vector<IntT> inputs(N, static_cast<IntT>(-1));
5050
return inputs;
5151
}
5252

5353
template <class IntT>
54-
inline std::vector<IntT> getSortedIntegerInputs(size_t N) {
54+
inline std::vector<IntT> getSortedIntegerInputs(std::size_t N) {
5555
std::vector<IntT> inputs;
56-
for (size_t i = 0; i < N; i += 1)
56+
for (std::size_t i = 0; i < N; i += 1)
5757
inputs.push_back(i);
5858
return inputs;
5959
}
6060

6161
template <class IntT>
62-
std::vector<IntT> getSortedLargeIntegerInputs(size_t N) {
62+
std::vector<IntT> getSortedLargeIntegerInputs(std::size_t N) {
6363
std::vector<IntT> inputs;
64-
for (size_t i = 0; i < N; ++i) {
64+
for (std::size_t i = 0; i < N; ++i)
6565
inputs.push_back(i + N);
66-
}
6766
return inputs;
6867
}
6968

7069
template <class IntT>
71-
std::vector<IntT> getSortedTopBitsIntegerInputs(size_t N) {
70+
std::vector<IntT> getSortedTopBitsIntegerInputs(std::size_t N) {
7271
std::vector<IntT> inputs = getSortedIntegerInputs<IntT>(N);
7372
for (auto& E : inputs)
7473
E <<= ((sizeof(IntT) / 2) * CHAR_BIT);
7574
return inputs;
7675
}
7776

7877
template <class IntT>
79-
inline std::vector<IntT> getReverseSortedIntegerInputs(size_t N) {
78+
inline std::vector<IntT> getReverseSortedIntegerInputs(std::size_t N) {
8079
std::vector<IntT> inputs;
8180
std::size_t i = N;
8281
while (i > 0) {
@@ -87,61 +86,58 @@ inline std::vector<IntT> getReverseSortedIntegerInputs(size_t N) {
8786
}
8887

8988
template <class IntT>
90-
std::vector<IntT> getPipeOrganIntegerInputs(size_t N) {
89+
std::vector<IntT> getPipeOrganIntegerInputs(std::size_t N) {
9190
std::vector<IntT> v;
9291
v.reserve(N);
93-
for (size_t i = 0; i < N / 2; ++i)
92+
for (std::size_t i = 0; i < N / 2; ++i)
9493
v.push_back(i);
95-
for (size_t i = N / 2; i < N; ++i)
94+
for (std::size_t i = N / 2; i < N; ++i)
9695
v.push_back(N - i);
9796
return v;
9897
}
9998

10099
template <class IntT>
101-
std::vector<IntT> getRandomIntegerInputs(size_t N) {
100+
std::vector<IntT> getRandomIntegerInputs(std::size_t N) {
102101
std::vector<IntT> inputs;
103-
for (size_t i = 0; i < N; ++i) {
102+
for (std::size_t i = 0; i < N; ++i)
104103
inputs.push_back(getRandomInteger<IntT>(0, std::numeric_limits<IntT>::max()));
105-
}
106104
return inputs;
107105
}
108106

109-
inline std::vector<std::string> getDuplicateStringInputs(size_t N) {
107+
inline std::vector<std::string> getDuplicateStringInputs(std::size_t N) {
110108
std::vector<std::string> inputs(N, getRandomString(1024));
111109
return inputs;
112110
}
113111

114-
inline std::vector<std::string> getRandomStringInputs(size_t N) {
112+
inline std::vector<std::string> getRandomStringInputs(std::size_t N) {
115113
std::vector<std::string> inputs;
116-
for (size_t i = 0; i < N; ++i) {
114+
for (std::size_t i = 0; i < N; ++i)
117115
inputs.push_back(getRandomString(1024));
118-
}
119116
return inputs;
120117
}
121118

122-
inline std::vector<std::string> getPrefixedRandomStringInputs(size_t N) {
119+
inline std::vector<std::string> getPrefixedRandomStringInputs(std::size_t N) {
123120
std::vector<std::string> inputs;
124121
constexpr int kSuffixLength = 32;
125122
const std::string prefix = getRandomString(1024 - kSuffixLength);
126-
for (size_t i = 0; i < N; ++i) {
123+
for (std::size_t i = 0; i < N; ++i)
127124
inputs.push_back(prefix + getRandomString(kSuffixLength));
128-
}
129125
return inputs;
130126
}
131127

132-
inline std::vector<std::string> getSortedStringInputs(size_t N) {
128+
inline std::vector<std::string> getSortedStringInputs(std::size_t N) {
133129
std::vector<std::string> inputs = getRandomStringInputs(N);
134130
std::sort(inputs.begin(), inputs.end());
135131
return inputs;
136132
}
137133

138-
inline std::vector<std::string> getReverseSortedStringInputs(size_t N) {
134+
inline std::vector<std::string> getReverseSortedStringInputs(std::size_t N) {
139135
std::vector<std::string> inputs = getSortedStringInputs(N);
140136
std::reverse(inputs.begin(), inputs.end());
141137
return inputs;
142138
}
143139

144-
inline std::vector<const char*> getRandomCStringInputs(size_t N) {
140+
inline std::vector<const char*> getRandomCStringInputs(std::size_t N) {
145141
static std::vector<std::string> inputs = getRandomStringInputs(N);
146142
std::vector<const char*> cinputs;
147143
for (auto const& str : inputs)

0 commit comments

Comments
 (0)