Skip to content

Commit 3af87d4

Browse files
[libc] Remove asm-generic includes from tests (#114479)
We shouldn't be including headers directly from asm-generic for macros. It's safer to get those through the correct primary header where possible (e.g. fcntl instead of asm-generic/fcntl). For our public headers we may need to include the asm-generic headers instead of defining all the macros ourselves, but that's something for a followup PR.
1 parent cf3464b commit 3af87d4

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

libc/test/src/search/hsearch_test.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include "src/search/hsearch.h"
1616
#include "test/UnitTest/ErrnoSetterMatcher.h"
1717
#include "test/UnitTest/Test.h"
18-
#include <asm-generic/errno-base.h>
1918

2019
TEST(LlvmLibcHsearchTest, CreateTooLarge) {
2120
using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Fails;

libc/test/src/sys/mman/linux/mlock_test.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
#include "test/UnitTest/LibcTest.h"
2424
#include "test/UnitTest/Test.h"
2525

26-
#include <asm-generic/errno-base.h>
27-
#include <asm-generic/mman.h>
2826
#include <linux/capability.h>
2927
#include <sys/mman.h>
3028
#include <sys/resource.h>

0 commit comments

Comments
 (0)